Merge pull request #24 from lociii/hide_empty

Add option (MENU_HIDE_EMPTY) to hide empty menu items

Author: borgstrom

docs/configuration.rst

@@ -11,5 +11,12 @@ MENU_SELECT_PARENTS
 their ``selected`` property set to ``True`` if one of their children has its
 ``selected`` property set to ``True``.
 
+MENU_HIDE_EMPTY
+-------------------
+**Default: ``False``**
+
+``MENU_HIDE_EMPTY`` controls if menu items without an explicit ``check`` callback
+should be visible even if they have no children
+
 
 .. _Django settings file: https://docs.djangoproject.com/en/dev/topics/settings/

menu/menu.py

@@ -185,18 +185,24 @@ def process(self, request):
         if not self.visible:
             return
 
+        # evaluate title
         self.check_title(request)
-        self.check_children(request)
 
-        children = [
-            kid
-            for kid in self.children
-            if kid.visible
-        ]
+        # evaluate children
+        visible_children = []
+        self.check_children(request)
+        for child in self.children:
+            child.process(request)
+            if child.visible:
+                visible_children.append(child)
+
+        hide_empty = getattr(settings, 'MENU_HIDE_EMPTY', False)
+        if hide_empty and not self.check and not len(visible_children):
+            self.visible = False
+            return
 
         curitem = None
-        for item in children:
-            item.process(request)
+        for item in visible_children:
             item.selected = False
 
             if item.match_url(request):