Skip to content

Commit 0b50ee6

Browse files
authored
Fix tests (#769)
1 parent 53ac872 commit 0b50ee6

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

rest_framework_simplejwt/utils.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from django.conf import settings
77
from django.utils.functional import lazy
8-
from django.utils.timezone import is_naive, make_aware
98

109

1110
def get_md5_hash_password(password: str) -> str:
@@ -16,8 +15,8 @@ def get_md5_hash_password(password: str) -> str:
1615

1716

1817
def make_utc(dt: datetime) -> datetime:
19-
if settings.USE_TZ and is_naive(dt):
20-
return make_aware(dt, timezone=timezone.utc)
18+
if settings.USE_TZ and dt.tzinfo is None:
19+
return dt.replace(tzinfo=timezone.utc)
2120

2221
return dt
2322

tests/test_init.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
from importlib import reload
2+
from importlib.metadata import PackageNotFoundError
23
from unittest.mock import Mock, patch
34

45
from django.test import SimpleTestCase
5-
from pkg_resources import DistributionNotFound
66

77

88
class TestInit(SimpleTestCase):
99
def test_package_is_not_installed(self):
1010
with patch(
11-
"pkg_resources.get_distribution", Mock(side_effect=DistributionNotFound)
11+
"importlib.metadata.version", Mock(side_effect=PackageNotFoundError)
1212
):
13-
# Import package mock package is not installed
1413
import rest_framework_simplejwt.__init__
1514

1615
self.assertEqual(rest_framework_simplejwt.__init__.__version__, None)

tests/test_utils.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from datetime import datetime, timedelta
1+
from datetime import datetime, timedelta, timezone
22

33
from django.test import TestCase
4-
from django.utils import timezone
54
from freezegun import freeze_time
65

76
from rest_framework_simplejwt.utils import (
@@ -24,11 +23,11 @@ def test_it_should_return_the_correct_values(self):
2423

2524
with self.settings(USE_TZ=False):
2625
dt = make_utc(dt)
27-
self.assertTrue(timezone.is_naive(dt))
26+
self.assertTrue(dt.tzinfo is None)
2827

2928
with self.settings(USE_TZ=True):
3029
dt = make_utc(dt)
31-
self.assertTrue(timezone.is_aware(dt))
30+
self.assertTrue(dt.tzinfo is not None)
3231
self.assertEqual(dt.utcoffset(), timedelta(seconds=0))
3332

3433

@@ -39,9 +38,7 @@ def test_it_should_return_the_correct_value(self):
3938
with freeze_time(now):
4039
# Should return aware utcnow if USE_TZ == True
4140
with self.settings(USE_TZ=True):
42-
self.assertEqual(
43-
timezone.make_aware(now, timezone=timezone.utc), aware_utcnow()
44-
)
41+
self.assertEqual(now.replace(tzinfo=timezone.utc), aware_utcnow())
4542

4643
# Should return naive utcnow if USE_TZ == False
4744
with self.settings(USE_TZ=False):

0 commit comments

Comments
 (0)