ref: full tracebacks on exceptions (#870)

Author: vgrozdanic

rest_framework_simplejwt/authentication.py

@@ -123,13 +123,17 @@ def get_user(self, validated_token: Token) -> AuthUser:
         """
         try:
             user_id = validated_token[api_settings.USER_ID_CLAIM]
-        except KeyError:
-            raise InvalidToken(_("Token contained no recognizable user identification"))
+        except KeyError as e:
+            raise InvalidToken(
+                _("Token contained no recognizable user identification")
+            ) from e
 
         try:
             user = self.user_model.objects.get(**{api_settings.USER_ID_FIELD: user_id})
-        except self.user_model.DoesNotExist:
-            raise AuthenticationFailed(_("User not found"), code="user_not_found")
+        except self.user_model.DoesNotExist as e:
+            raise AuthenticationFailed(
+                _("User not found"), code="user_not_found"
+            ) from e
 
         if api_settings.CHECK_USER_IS_ACTIVE and not user.is_active:
             raise AuthenticationFailed(_("User is inactive"), code="user_inactive")

rest_framework_simplejwt/backends.py

@@ -121,8 +121,8 @@ def get_verifying_key(self, token: Token) -> Any:
         if self.jwks_client:
             try:
                 return self.jwks_client.get_signing_key_from_jwt(token).key
-            except PyJWKClientError as ex:
-                raise TokenBackendError(_("Token is invalid")) from ex
+            except PyJWKClientError as e:
+                raise TokenBackendError(_("Token is invalid")) from e
 
         return self.prepared_verifying_key
 
@@ -169,9 +169,9 @@ def decode(self, token: Token, verify: bool = True) -> dict[str, Any]:
                     "verify_signature": verify,
                 },
             )
-        except InvalidAlgorithmError as ex:
-            raise TokenBackendError(_("Invalid algorithm specified")) from ex
-        except ExpiredSignatureError as ex:
-            raise TokenBackendExpiredToken(_("Token is expired")) from ex
-        except InvalidTokenError as ex:
-            raise TokenBackendError(_("Token is invalid")) from ex
+        except InvalidAlgorithmError as e:
+            raise TokenBackendError(_("Invalid algorithm specified")) from e
+        except ExpiredSignatureError as e:
+            raise TokenBackendExpiredToken(_("Token is expired")) from e
+        except InvalidTokenError as e:
+            raise TokenBackendError(_("Token is invalid")) from e

rest_framework_simplejwt/tokens.py

@@ -63,10 +63,10 @@ def __init__(self, token: Optional["Token"] = None, verify: bool = True) -> None
             # Decode token
             try:
                 self.payload = token_backend.decode(token, verify=verify)
-            except TokenBackendExpiredToken:
-                raise ExpiredTokenError(_("Token is expired"))
-            except TokenBackendError:
-                raise TokenError(_("Token is invalid"))
+            except TokenBackendExpiredToken as e:
+                raise ExpiredTokenError(_("Token is expired")) from e
+            except TokenBackendError as e:
+                raise TokenError(_("Token is invalid")) from e
 
             if verify:
                 self.verify()
@@ -135,8 +135,8 @@ def verify_token_type(self) -> None:
         """
         try:
             token_type = self.payload[api_settings.TOKEN_TYPE_CLAIM]
-        except KeyError:
-            raise TokenError(_("Token has no type"))
+        except KeyError as e:
+            raise TokenError(_("Token has no type")) from e
 
         if self.token_type != token_type:
             raise TokenError(_("Token has wrong type"))
@@ -197,8 +197,8 @@ def check_exp(
 
         try:
             claim_value = self.payload[claim]
-        except KeyError:
-            raise TokenError(format_lazy(_("Token has no '{}' claim"), claim))
+        except KeyError as e:
+            raise TokenError(format_lazy(_("Token has no '{}' claim"), claim)) from e
 
         claim_time = datetime_from_epoch(claim_value)
         leeway = self.get_token_backend().get_leeway()

rest_framework_simplejwt/views.py

@@ -27,9 +27,9 @@ def get_serializer_class(self) -> Serializer:
             return self.serializer_class
         try:
             return import_string(self._serializer_class)
-        except ImportError:
+        except ImportError as e:
             msg = f"Could not import serializer '{self._serializer_class}'"
-            raise ImportError(msg)
+            raise ImportError(msg) from e
 
     def get_authenticate_header(self, request: Request) -> str:
         return '{} realm="{}"'.format(
@@ -43,7 +43,7 @@ def post(self, request: Request, *args, **kwargs) -> Response:
         try:
             serializer.is_valid(raise_exception=True)
         except TokenError as e:
-            raise InvalidToken(e.args[0])
+            raise InvalidToken(e.args[0]) from e
 
         return Response(serializer.validated_data, status=status.HTTP_200_OK)