Merge pull request #4 from paulvanbladel/master

jbogard · web-flow · commit bf7bfdd4d96f · 2017-11-18T04:13:16.000-06:00
fix: DbContextTransactionFilter needs explicit check on exception inner action
diff --git a/ContosoUniversity/Infrastructure/DbContextTransactionFilter.cs b/ContosoUniversity/Infrastructure/DbContextTransactionFilter.cs
@@ -20,9 +20,17 @@ public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionE
             {
                 await _dbContext.BeginTransactionAsync();
 
-                await next();
+                var actionExecuted = await next();
+                if (actionExecuted.Exception != null && !actionExecuted.ExceptionHandled)
+                {
+                    _dbContext.RollbackTransaction();
 
-                await _dbContext.CommitTransactionAsync();
+                }
+                else
+                {
+                    await _dbContext.CommitTransactionAsync();
+
+                }
             }
             catch (Exception)
             {

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,17 @@ public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionE`
`20`	`20`	`{`
`21`	`21`	`await _dbContext.BeginTransactionAsync();`
`22`	`22`
`23`		`- await next();`
	`23`	`+ var actionExecuted = await next();`
	`24`	`+ if (actionExecuted.Exception != null && !actionExecuted.ExceptionHandled)`
	`25`	`+ {`
	`26`	`+ _dbContext.RollbackTransaction();`
`24`	`27`
`25`		`- await _dbContext.CommitTransactionAsync();`
	`28`	`+ }`
	`29`	`+ else`
	`30`	`+ {`
	`31`	`+ await _dbContext.CommitTransactionAsync();`
	`32`	`+`
	`33`	`+ }`
`26`	`34`	`}`
`27`	`35`	`catch (Exception)`
`28`	`36`	`{`