fixes for ip theoretically being undefined (never actually happened)

Author: jboolean

backend/src/api/AuthenticationController.ts

@@ -56,12 +56,10 @@ export class AuthenticationController extends Controller {
   ): Promise<LoginResponse> {
     const userId = await getUserFromRequestOrCreateAndSetCookie(req);
     const { requestedEmail, returnToPath, requireVerifiedEmail } = loginRequest;
-    const ipAddress = req.ip;
     const apiBase = `${req.protocol}://${required(req.get('host'), 'host')}`;
     const result = await UserService.processLoginRequest(
       requestedEmail,
       userId,
-      ipAddress,
       apiBase,
       returnToPath,
       requireVerifiedEmail

backend/src/api/auth/userAuthUtils.ts

@@ -1,5 +1,5 @@
-import * as UserService from '../../business/users/UserService';
 import * as express from 'express';
+import * as UserService from '../../business/users/UserService';
 import { setAuthCookie } from './authCookieUtils';
 
 export const USER_TOKEN_COOKIE = 'user-token';
@@ -25,7 +25,7 @@ export async function getUserFromRequestOrCreateAndSetCookie(
   }
 
   if (!token || !userId) {
-    const userCreationResult = await UserService.createUser(req.ip);
+    const userCreationResult = await UserService.createUser(req.ip as string);
     userId = userCreationResult.userId;
     token = userCreationResult.token;
   }

backend/src/business/users/UserService.ts

@@ -150,7 +150,6 @@ async function sendMagicLink(
 export async function processLoginRequest(
   requestedEmail: string,
   authenticatedUserId: number,
-  ipAddress: string,
   apiBase: string,
   returnToPath?: string,
   requireVerifiedEmail = false