more linting

Author: jbowes

example_test.go

@@ -14,16 +14,16 @@ const secret = "support-your-local-cat-bonnet-store"
 func Example_round_trip() {
 	h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "text/plain")
-		io.WriteString(w, "Your request has a valid signature!")
+		_, _ = io.WriteString(w, "Your request has a valid signature!")
 	})
-	
+
 	middleware := httpsig.NewVerifyMiddleware(httpsig.WithHmacSha256("key1", []byte(secret)))
 	http.Handle("/", middleware(h))
-	go func() { http.ListenAndServe("127.0.0.1:1234", http.DefaultServeMux) }()
+	go func() { _ = http.ListenAndServe("127.0.0.1:1234", http.DefaultServeMux) }()
 
 	// Give the server time to sleep. Terrible, I know.
 	time.Sleep(100 * time.Millisecond)
-	
+
 	client := http.Client{
 		// Wrap the transport:
 		Transport: httpsig.NewSignTransport(http.DefaultTransport,

httpsig.go

@@ -122,7 +122,7 @@ func NewVerifyMiddleware(opts ...verifyOption) func(http.Handler) http.Handler {
 		rw.Header().Set("Content-Type", "text/plain")
 		rw.WriteHeader(http.StatusBadRequest)
 
-		rw.Write([]byte("invalid required signature"))
+		_, _ = rw.Write([]byte("invalid required signature"))
 	}
 
 	return func(h http.Handler) http.Handler {

sign.go

@@ -84,8 +84,14 @@ func (s *signer) Sign(msg *message) (http.Header, error) {
 		sps[fmt.Sprintf("sig%d", i)] = sp.canonicalize()
 
 		signer := si.signer()
-		signer.w.Write(b.Bytes())
-		canonicalizeSignatureParams(signer.w, sp)
+		if _, err := signer.w.Write(b.Bytes()); err != nil {
+			return nil, err
+		}
+
+		if err := canonicalizeSignatureParams(signer.w, sp); err != nil {
+			return nil, err
+		}
+
 		sigs[fmt.Sprintf("sig%d", i)] = base64.StdEncoding.EncodeToString(signer.sign())
 
 		i++

verify.go

@@ -134,8 +134,13 @@ func (v *verifier) Verify(msg *message) error {
 		}
 	}
 
-	verifier.w.Write(b.Bytes())
-	canonicalizeSignatureParams(verifier.w, params)
+	if _, err := verifier.w.Write(b.Bytes()); err != nil {
+		return err
+	}
+
+	if err = canonicalizeSignatureParams(verifier.w, params); err != nil {
+		return err
+	}
 
 	err = verifier.verify(sig)
 	if err != nil {