Commit d86ebfd
committed
Fix CompareCommandSettings parameterless constructor issue and improve integration tests
- Remove 'required' keyword from CompareCommandSettings properties to allow Spectre.Console.Cli to instantiate the class
- Add proper null validation in the Validate method instead
- Fix integration tests to use correct 'compare' command syntax
- Add proper test categories [Trait("Category", "Integration")] to integration tests
- Fix path resolution in FindExecutablePath method (5 levels up instead of 4)
- Replace silent test skipping with proper assertions that fail when prerequisites aren't met
- All 345 tests now pass including 27 integration tests
Fixes the CLI error: 'Could not resolve type CompareCommandSettings - No parameterless constructor defined'1 parent 5d55f62 commit d86ebfd
File tree
3 files changed
+83
-151
lines changed- src/DotNetApiDiff/Commands
- tests/DotNetApiDiff.Tests/Integration
3 files changed
+83
-151
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
98 | 103 | | |
99 | 104 | | |
100 | 105 | | |
101 | 106 | | |
102 | 107 | | |
103 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
104 | 114 | | |
105 | 115 | | |
106 | 116 | | |
| |||
203 | 213 | | |
204 | 214 | | |
205 | 215 | | |
206 | | - | |
| 216 | + | |
207 | 217 | | |
208 | 218 | | |
209 | 219 | | |
| |||
216 | 226 | | |
217 | 227 | | |
218 | 228 | | |
219 | | - | |
| 229 | + | |
220 | 230 | | |
221 | 231 | | |
222 | 232 | | |
| |||
0 commit comments