Skip to content

Commit 2f3184d

Browse files
committed
chromium: Remove defunct LLVM version check logic
The new core LLVM support lacks an equivalent of LLVMVERSION as exposed by meta-clang, resulting in this benign WARNING: WARNING: mc:house:chromium-ozone-wayland-140.0.7339.136-r0 do_check_llvm_version: Unable to determine LLVM version. Chromium may not be compiled successfully if the LLVM version is below 14.0.0. LLVM-14 was released nearly four years ago. Upstream chromium's current policy is summarized here: https://chromium.googlesource.com/chromium/src/+/main/docs/toolchain_support.md ...and quoting the releavant portion: Even within clang/libc++, we often rely on recent bugfixes and feature additions, so generally only the most recent LLVM version is supported. Silence the warning by dropping the bitrotted version enforement logic. Signed-off-by: Calvin Owens <[email protected]>
1 parent 6954886 commit 2f3184d

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -420,26 +420,6 @@ python do_create_v8_qemu_wrapper () {
420420
do_create_v8_qemu_wrapper[dirs] = "${B}"
421421
addtask create_v8_qemu_wrapper after do_patch before do_configure
422422

423-
# Check the LLVMVERSION defined in the meta-clang layer. Given Chromium is
424-
# developed using new C++ features, the LLVMVERSION has to be >= 14. Otherwise,
425-
# it is not guaranteed that Chromium will compile.
426-
python do_check_llvm_version () {
427-
from distutils.version import LooseVersion
428-
429-
min_llvm_version = "14.0.0"
430-
llvm_version = d.getVar('LLVMVERSION', False)
431-
if not llvm_version:
432-
bb.warn("Unable to determine LLVM version. Chromium may not be compiled "
433-
"successfully if the LLVM version is below %s." % min_llvm_version)
434-
return
435-
436-
if LooseVersion(llvm_version) < LooseVersion(min_llvm_version):
437-
bb.fatal("Your LLVMVERSION (%s) is lower than the minimum required "
438-
"LLVMVERSION (%s). If you are using dunfell, make sure you "
439-
"use dunfell-clang14 branch." % (llvm_version, min_llvm_version))
440-
}
441-
addtask check_llvm_version before do_configure
442-
443423
python do_write_toolchain_file () {
444424
"""Writes a BUILD.gn file for Yocto detailing its toolchains."""
445425
toolchain_dir = d.expand("${S}/build/toolchain/yocto")

0 commit comments

Comments
 (0)