Skip to content

Commit 7003087

Browse files
Update xUnit to v3 and fix ValueTask return types
Co-authored-by: JohnCampionJr <[email protected]>
1 parent 27165d9 commit 7003087

24 files changed

+47
-47
lines changed

tests/MongoFramework.AspNetCore.Identity.Tests/MongoEntityFramework.AspNetCore.Identity.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<ItemGroup>
2020
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
2121
<PackageReference Include="AwesomeAssertions" Version="9.2.1" />
22-
<PackageReference Include="xunit" Version="2.9.3" />
22+
<PackageReference Include="xunit.v3" Version="3.2.0-pre.10" />
2323
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
2424
<PrivateAssets>all</PrivateAssets>
2525
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityContextsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class MongoIdentityContextsTests : TestBase, IAsyncLifetime
2222

2323
public MongoIdentityContextsTests() : base("MongoIdentityContexts") { }
2424

25-
public async Task InitializeAsync()
25+
public async ValueTask InitializeAsync()
2626
{
2727
var context = new MongoIdentityDbContext(GetConnection());
2828
var store = new MongoUserStore<MongoIdentityUser>(context);
@@ -40,7 +40,7 @@ public async Task InitializeAsync()
4040

4141
}
4242

43-
public Task DisposeAsync() => Task.CompletedTask;
43+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
4444

4545
[Fact]
4646
public void ContextWithRolesLoadsRoles()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoRoleStoreTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class MongoRoleStoreTests : TestBase, IAsyncLifetime
1212

1313
public MongoRoleStoreTests() : base("MongoRoleStore") { }
1414

15-
public async Task InitializeAsync()
15+
public async ValueTask InitializeAsync()
1616
{
1717
var context = new MongoTestContext(GetConnection());
1818
var store = new MongoUserStore<MongoTestUser>(context);
@@ -30,7 +30,7 @@ public async Task InitializeAsync()
3030

3131
}
3232

33-
public Task DisposeAsync() => Task.CompletedTask;
33+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
3434

3535
[Fact]
3636
public void ConstructorUsesMongo()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ public class AddClaims : TestBase, IAsyncLifetime
1414

1515
public AddClaims() : base("MongoUserOnlyStore-AddClaims") { }
1616

17-
public async Task InitializeAsync()
17+
public async ValueTask InitializeAsync()
1818
{
1919
var context = new MongoTestContext(GetConnection());
2020
var store = new MongoUserOnlyStore<MongoTestUser>(context);
2121

2222
await store.CreateAsync(MongoTestUser.First);
2323
}
2424

25-
public Task DisposeAsync() => Task.CompletedTask;
25+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
2626

2727
[Fact]
2828
public async Task UpdatesUser()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class AddLogin : TestBase, IAsyncLifetime
1414

1515
public AddLogin() : base("MongoUserOnlyStore-AddLogin") { }
1616

17-
public async Task InitializeAsync()
17+
public async ValueTask InitializeAsync()
1818
{
1919
var context = new MongoTestContext(GetConnection());
2020
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -24,7 +24,7 @@ public async Task InitializeAsync()
2424
await store.CreateAsync(MongoTestUser.Third);
2525
}
2626

27-
public Task DisposeAsync() => Task.CompletedTask;
27+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
2828

2929
[Fact]
3030
public async Task UpdatesUser()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByEmail.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class FindByEmail : TestBase, IAsyncLifetime
1313

1414
public FindByEmail() : base("MongoUserOnlyStore-FindByEmail") { }
1515

16-
public async Task InitializeAsync()
16+
public async ValueTask InitializeAsync()
1717
{
1818
var context = new MongoTestContext(GetConnection());
1919
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -23,7 +23,7 @@ public async Task InitializeAsync()
2323
await store.CreateAsync(MongoTestUser.Third);
2424
}
2525

26-
public Task DisposeAsync() => Task.CompletedTask;
26+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
2727

2828
[Fact]
2929
public async Task FindsCorrectUserWithValidEmail()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class FindById : TestBase, IAsyncLifetime
1414

1515
public FindById() : base("MongoUserOnlyStore-FindById") { }
1616

17-
public async Task InitializeAsync()
17+
public async ValueTask InitializeAsync()
1818
{
1919
var context = new MongoTestContext(GetConnection());
2020
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -28,7 +28,7 @@ public async Task InitializeAsync()
2828
await store2.CreateAsync(MongoTestUserInt.Third);
2929
}
3030

31-
public Task DisposeAsync() => Task.CompletedTask;
31+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
3232

3333
[Fact]
3434
public async Task FindsCorrectUserWithValidStringId()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public async Task<IdentityUserLogin<string>> ExposeFindUserLoginAsync(string use
2525

2626
public FindByLogin() : base("MongoUserOnlyStore-FindByLogin") { }
2727

28-
public async Task InitializeAsync()
28+
public async ValueTask InitializeAsync()
2929
{
3030
var context = new MongoTestContext(GetConnection());
3131
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -44,7 +44,7 @@ public async Task InitializeAsync()
4444

4545
}
4646

47-
public Task DisposeAsync() => Task.CompletedTask;
47+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
4848

4949
[Fact]
5050
public async Task GetsCorrectUserFromLogin()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class FindByName : TestBase, IAsyncLifetime
1313

1414
public FindByName() : base("MongoUserOnlyStore-FindByName") { }
1515

16-
public async Task InitializeAsync()
16+
public async ValueTask InitializeAsync()
1717
{
1818
var context = new MongoTestContext(GetConnection());
1919
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -23,7 +23,7 @@ public async Task InitializeAsync()
2323
await store.CreateAsync(MongoTestUser.Third);
2424
}
2525

26-
public Task DisposeAsync() => Task.CompletedTask;
26+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
2727

2828
[Fact]
2929
public async Task FindsCorrectUserWithValidUserName()

tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class GetClaims : TestBase, IAsyncLifetime
1414

1515
public GetClaims() : base("MongoUserOnlyStore-GetClaims") { }
1616

17-
public async Task InitializeAsync()
17+
public async ValueTask InitializeAsync()
1818
{
1919
var context = new MongoTestContext(GetConnection());
2020
var store = new MongoUserOnlyStore<MongoTestUser>(context);
@@ -31,7 +31,7 @@ await store.AddClaimsAsync(user,
3131

3232
}
3333

34-
public Task DisposeAsync() => Task.CompletedTask;
34+
public ValueTask DisposeAsync() => ValueTask.CompletedTask;
3535

3636
[Fact]
3737
public async Task RetrievesClaimsFromUser()

0 commit comments

Comments
 (0)