feature: csharp 12

Author: jcdcdev

src/Umbraco.Community.DataProtection/Persistence/DataProtectionMigration.cs

@@ -10,21 +10,18 @@
 
 namespace Umbraco.Community.DataProtection.Persistence;
 
-public class DataProtectionMigration : PackageMigrationBase
-{
-    public DataProtectionMigration(
-        IPackagingService packagingService,
-        IMediaService mediaService,
-        MediaFileManager mediaFileManager,
-        MediaUrlGeneratorCollection mediaUrlGenerators,
-        IShortStringHelper shortStringHelper,
-        IContentTypeBaseServiceProvider contentTypeBaseServiceProvider,
-        IMigrationContext context,
-        IOptions<PackageMigrationSettings> packageMigrationsSettings) : base(packagingService, mediaService, mediaFileManager, mediaUrlGenerators, shortStringHelper, contentTypeBaseServiceProvider,
+public class DataProtectionMigration(
+    IPackagingService packagingService,
+    IMediaService mediaService,
+    MediaFileManager mediaFileManager,
+    MediaUrlGeneratorCollection mediaUrlGenerators,
+    IShortStringHelper shortStringHelper,
+    IContentTypeBaseServiceProvider contentTypeBaseServiceProvider,
+    IMigrationContext context,
+    IOptions<PackageMigrationSettings> packageMigrationsSettings)
+    : PackageMigrationBase(packagingService, mediaService, mediaFileManager, mediaUrlGenerators, shortStringHelper, contentTypeBaseServiceProvider,
         context, packageMigrationsSettings)
-    {
-    }
-
+{
     protected override void Migrate()
     {
         if (!TableExists(Constants.Tables.DataProtectionKeys))

src/Umbraco.Community.DataProtection/Persistence/MigrationPlan.cs

@@ -2,12 +2,8 @@
 
 namespace Umbraco.Community.DataProtection.Persistence;
 
-public class MigrationPlan : PackageMigrationPlan
+public class MigrationPlan() : PackageMigrationPlan(Constants.PackageId)
 {
-    public MigrationPlan() : base(Constants.PackageId)
-    {
-    }
-
     protected override void DefinePlan()
     {
         To<DataProtectionMigration>(nameof(DataProtectionMigration));

src/Umbraco.Community.DataProtection/Persistence/UmbracoXmlRepository.cs

@@ -7,22 +7,13 @@
 
 namespace Umbraco.Community.DataProtection.Persistence;
 
-public class UmbracoXmlRepository : IXmlRepository
+public class UmbracoXmlRepository(IScopeProvider scopeProvider, ILogger<UmbracoXmlRepository> logger) : IXmlRepository
 {
-    private readonly ILogger<UmbracoXmlRepository> _logger;
-    private readonly IScopeProvider _scopeProvider;
-
-    public UmbracoXmlRepository(IScopeProvider scopeProvider, ILogger<UmbracoXmlRepository> logger)
-    {
-        _scopeProvider = scopeProvider;
-        _logger = logger;
-    }
-
     public IReadOnlyCollection<XElement> GetAllElements()
     {
         try
         {
-            using var scope = _scopeProvider.CreateScope();
+            using var scope = scopeProvider.CreateScope();
             var sql = scope.SqlContext.Sql().SelectAll().From<DataProtectionKey>();
             var results = scope.Database.Fetch<DataProtectionKey>(sql);
             var output = results.Select(x => XElement.Parse(x.Xml!)).WhereNotNull().ToList().AsReadOnly();
@@ -31,7 +22,7 @@ public IReadOnlyCollection<XElement> GetAllElements()
         }
         catch (Exception ex)
         {
-            _logger.LogError(ex, "Error getting all elements");
+            logger.LogError(ex, "Error getting all elements");
             return Array.Empty<XElement>();
         }
     }
@@ -40,7 +31,7 @@ public void StoreElement(XElement element, string friendlyName)
     {
         try
         {
-            using var scope = _scopeProvider.CreateScope(autoComplete: false);
+            using var scope = scopeProvider.CreateScope(autoComplete: false);
             var key = new DataProtectionKey
             {
                 FriendlyName = friendlyName,
@@ -51,7 +42,7 @@ public void StoreElement(XElement element, string friendlyName)
         }
         catch (Exception ex)
         {
-            _logger.LogError(ex, "Error storing element");
+            logger.LogError(ex, "Error storing element");
         }
     }
 }

src/Umbraco.Community.DataProtection/Umbraco.Community.DataProtection.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Razor">
     <PropertyGroup>
         <TargetFramework>net8.0</TargetFramework>
-        <LangVersion>10</LangVersion>
+        <LangVersion>12</LangVersion>
         <AddRazorSupportForMvc>true</AddRazorSupportForMvc>
         <Nullable>enable</Nullable>
         <ImplicitUsings>enable</ImplicitUsings>