Multiple apns client instances and eventLoopGroup

[thend03]

In my project, an instance of apns client will be created for each application.

The following 2 ways to create apnsclient, which method is better and more reasonable

public ApnsClient createApnsClient() throws IOException {
        //create a new EventLoopGroup for each apns client instance
        EventLoopGroup eventLoopGroup = new NioEventLoopGroup(8);
        final ApnsClient apnsClient = new ApnsClientBuilder()
                .setApnsServer(ApnsClientBuilder.DEVELOPMENT_APNS_HOST)
                .setEventLoopGroup(eventLoopGroup)
                .setClientCredentials(new File("/path/to/certificate.p12"), "p12-file-password")
                .setConcurrentConnections(16)
                .build();
        return apnsClient;
    }

/**
     * all the apns client share the EventLoopGroup
     */
    private static final EventLoopGroup EVENT_LOOP_GROUP = new NioEventLoopGroup(8);

    public ApnsClient createApnsClient() throws IOException {
        final ApnsClient apnsClient = new ApnsClientBuilder()
                .setApnsServer(ApnsClientBuilder.DEVELOPMENT_APNS_HOST)
                .setEventLoopGroup(EVENT_LOOP_GROUP)
                .setClientCredentials(new File("/path/to/certificate.p12"), "p12-file-password")
                .setConcurrentConnections(16)
                .build();
        return apnsClient;
    }

[jchambers]

If you have multiple clients, I recommend sharing an event loop group between them.

EDIT: Although it doesn't address this question directly, you may also find the "best practices" wiki page (and especially the section on threads, concurrent connections, and performance) helpful for understanding how event loop groups fit in to the picture.

[thend03]

thank you