Skip to content

Commit 731a11f

Browse files
committed
Typo fixes
1 parent e38a82b commit 731a11f

File tree

4 files changed

+26
-28
lines changed

4 files changed

+26
-28
lines changed

BotwinMediator/Features/Films/ListFilmById/ListFilmsByIdCommandHandler.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ public ListFilmsByIdCommandHandler(IListFilmByIdQuery listFilmByIdQuery, IGetDir
2323

2424
protected override object Execute(ListFilmsByIdCommand command)
2525
{
26-
//TODO Unit testing?
27-
2826
//Use shared query to get film
2927
var film = this.listFilmByIdQuery.Execute(command.Id);
3028

FunctionalProject/Features/FuncFilms/FilmsModule.cs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,30 @@ public FilmsModule() : base("/api/funcy/films")
2121
this.Delete("/{id:int}", this.DeleteFilm);
2222
}
2323

24+
private async Task GetFilms(HttpContext context)
25+
{
26+
var handler = RouteHandlers.ListFilmsHandler;
27+
28+
var films = handler();
29+
30+
await context.Response.AsJson(films);
31+
}
32+
33+
private async Task GetFilmById(HttpContext context)
34+
{
35+
var handler = RouteHandlers.ListFilmByIdHandler;
36+
37+
var film = handler(context.GetRouteData().As<int>("id"));
38+
39+
if (film == null)
40+
{
41+
context.Response.StatusCode = 404;
42+
return;
43+
}
44+
45+
await context.Response.AsJson(film);
46+
}
47+
2448
private async Task CreateFilm(HttpContext context)
2549
{
2650
var result = context.Request.BindAndValidate<Film>();
@@ -71,30 +95,6 @@ private async Task UpdateFilm(HttpContext context)
7195
}
7296
}
7397

74-
private async Task GetFilms(HttpContext context)
75-
{
76-
var handler = RouteHandlers.ListFilmsHandler;
77-
78-
var films = handler();
79-
80-
await context.Response.AsJson(films);
81-
}
82-
83-
private async Task GetFilmById(HttpContext context)
84-
{
85-
var handler = RouteHandlers.ListFilmByIdHandler;
86-
87-
var film = handler(context.GetRouteData().As<int>("id"));
88-
89-
if (film == null)
90-
{
91-
context.Response.StatusCode = 404;
92-
return;
93-
}
94-
95-
await context.Response.AsJson(film);
96-
}
97-
9898
private Task DeleteFilm(HttpContext context)
9999
{
100100
try

FunctionalProjectTests/Features/Films/FilmTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public async Task Should_get_film_by_id()
8484
{
8585
//Given
8686

87-
//No mock library required to fake the GetFilmBtIdDelegate, GetDirectorById, GetCastMembersByFilmId we just invoke a func
87+
//No mock library required to fake the GetFilmByIdDelegate, GetDirectorById, GetCastMembersByFilmId we just invoke a func
8888

8989
RouteHandlers.ListFilmByIdHandler = id => ListFilmByIdRoute.Handle(id, filmid => new Film { Name = "Blade Runner" }, i => new Director(), filmId => new[] { new CastMember() });
9090

@@ -101,7 +101,7 @@ public async Task Should_return_404_when_no_film_found_via_get_film_by_id()
101101
{
102102
//Given
103103

104-
//No mock library required to fake the GetFilmBtIdDelegate, GetDirectorById, GetCastMembersByFilmId we just invoke a func
104+
//No mock library required to fake the GetFilmByIdDelegate, GetDirectorById, GetCastMembersByFilmId we just invoke a func
105105

106106
RouteHandlers.ListFilmByIdHandler = id => ListFilmByIdRoute.Handle(id, filmid => null, i => new Director(), filmId => new[] { new CastMember() });
107107

Slides.pptx

197 KB
Binary file not shown.

0 commit comments

Comments
 (0)