Skip to content

Commit 1303a30

Browse files
committed
Remove circular reference
`line_edit` was both the parent and the central widget of `searchWidget`, causing a circular reference in the objects parenting (resulting in a segfault).
1 parent e0426d2 commit 1303a30

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

NodeGraphQt/base/graph.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class NodeGraph(QtCore.QObject):
7272
node_created = QtCore.Signal(NodeObject)
7373
"""
7474
Signal triggered when a node is created in the node graph.
75-
75+
7676
:parameters: :class:`NodeGraphQt.NodeObject`
7777
:emits: created node
7878
"""
@@ -86,15 +86,15 @@ class NodeGraph(QtCore.QObject):
8686
node_selected = QtCore.Signal(NodeObject)
8787
"""
8888
Signal triggered when a node is clicked with the LMB.
89-
89+
9090
:parameters: :class:`NodeGraphQt.NodeObject`
9191
:emits: selected node
9292
"""
9393
node_selection_changed = QtCore.Signal(list, list)
9494
"""
9595
Signal triggered when the node selection has changed.
9696
97-
:parameters: list[:class:`NodeGraphQt.NodeObject`],
97+
:parameters: list[:class:`NodeGraphQt.NodeObject`],
9898
list[:class:`NodeGraphQt.NodeObject`]
9999
:emits: selected node, deselected nodes.
100100
"""
@@ -109,27 +109,27 @@ class NodeGraph(QtCore.QObject):
109109
"""
110110
Signal triggered when a node port has been connected.
111111
112-
:parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
112+
:parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
113113
:emits: input port, output port
114114
"""
115115
port_disconnected = QtCore.Signal(Port, Port)
116116
"""
117117
Signal triggered when a node port has been disconnected.
118118
119-
:parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
119+
:parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
120120
:emits: input port, output port
121121
"""
122122
property_changed = QtCore.Signal(NodeObject, str, object)
123123
"""
124-
Signal is triggered when a property has changed on a node.
124+
Signal is triggered when a property has changed on a node.
125125
126126
:parameters: :class:`NodeGraphQt.BaseNode`, str, object
127127
:emits: triggered node, property name, property value
128128
"""
129129
data_dropped = QtCore.Signal(QtCore.QMimeData, QtCore.QPoint)
130130
"""
131131
Signal is triggered when data has been dropped to the graph.
132-
132+
133133
:parameters: :class:`PySide2.QtCore.QMimeData`, :class:`PySide2.QtCore.QPoint`
134134
:emits: mime data, node graph position
135135
"""
@@ -473,7 +473,7 @@ def viewer(self):
473473
by ``NodeGraphQt`` components.
474474
475475
See Also:
476-
:attr:`NodeGraph.widget` for adding the node graph into a
476+
:attr:`NodeGraph.widget` for adding the node graph into a
477477
:class:`PySide2.QtWidgets.QLayout`.
478478
479479
Returns:
@@ -567,9 +567,9 @@ def undo_stack(self):
567567
def clear_undo_stack(self):
568568
"""
569569
Clears the undo stack.
570-
570+
571571
Note:
572-
Convenience function to
572+
Convenience function to
573573
:meth:`NodeGraph.undo_stack().clear()`
574574
575575
See Also:
@@ -1331,7 +1331,7 @@ def save_session(self, file_path):
13311331
def load_session(self, file_path):
13321332
"""
13331333
Load node graph session layout file.
1334-
1334+
13351335
Args:
13361336
file_path (str): path to the serialized layout file.
13371337
"""
@@ -1341,7 +1341,7 @@ def load_session(self, file_path):
13411341
def import_session(self, file_path):
13421342
"""
13431343
Import node graph session layout file.
1344-
1344+
13451345
Args:
13461346
file_path (str): path to the serialized layout file.
13471347
"""

NodeGraphQt/widgets/tab_search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def __init__(self, node_dict=None):
141141
if self._node_dict:
142142
self._generate_items_from_node_dict()
143143

144-
searchWidget = QtWidgets.QWidgetAction(self.line_edit)
144+
searchWidget = QtWidgets.QWidgetAction(self)
145145
searchWidget.setDefaultWidget(self.line_edit)
146146
self.addAction(searchWidget)
147147
self.setStyleSheet(STYLE_QMENU)

0 commit comments

Comments
 (0)