make node text item editable

Author: ArnoChenFx

NodeGraphQt/base/node.py

@@ -325,6 +325,8 @@ def set_property(self, name, value):
             pass
 
         if self.graph and name == 'name':
+            if len(value) == 0:
+                value = '_'
             value = self.graph.get_unique_name(value)
             self.NODE_NAME = value
 
@@ -516,6 +518,7 @@ def __init__(self):
         self._inputs = []
         self._outputs = []
         self._has_draw = False
+        self._view.text_item.editingFinished.connect(self.set_name)
 
     def draw(self, force=True):
         if force:

NodeGraphQt/base/utils.py

@@ -339,12 +339,13 @@ def get_input_nodes(node):
     return list(nodes.values())
 
 
-def get_output_nodes(node):
+def get_output_nodes(node, cook=True):
     """
     Get output nodes of node.
 
     Args:
         node (NodeGraphQt.BaseNode).
+        cook (bool): call this function for cook node.
     Returns:
         list[NodeGraphQt.BaseNode].
     """
@@ -353,7 +354,7 @@ def get_output_nodes(node):
     for p in node.output_ports():
         for cp in p.connected_ports():
             n = cp.node()
-            if n.has_property('graph_rect'):
+            if cook and n.has_property('graph_rect'):
                 n.mark_node_to_be_cooked(cp)
             nodes[n.id] = n
     return list(nodes.values())
@@ -609,7 +610,7 @@ def update_nodes_by_up(nodes):
 
 def _update_node_rank_down(node, nodes_rank):
     rank = nodes_rank[node] + 1
-    for n in get_output_nodes(node):
+    for n in get_output_nodes(node, False):
         if n in nodes_rank:
             nodes_rank[n] = max(nodes_rank[n], rank)
         else:

NodeGraphQt/qgraphics/node_base.py

@@ -10,6 +10,7 @@
 from ..errors import NodeWidgetError
 from .node_abstract import AbstractNodeItem
 from .port import PortItem
+from .text_item import text_item
 
 
 class XDisabledItem(QtWidgets.QGraphicsItem):
@@ -127,7 +128,7 @@ def __init__(self, name='node', parent=None):
         self._properties['icon'] = ICON_NODE_BASE
         self._icon_item = QtWidgets.QGraphicsPixmapItem(pixmap, self)
         self._icon_item.setTransformationMode(QtCore.Qt.SmoothTransformation)
-        self._text_item = QtWidgets.QGraphicsTextItem(self.name, self)
+        self.text_item = text_item(self.name, self)
         self._x_item = XDisabledItem(self, 'DISABLED')
         self._input_items = {}
         self._output_items = {}
@@ -262,7 +263,7 @@ def _set_text_color(self, color):
             text.setDefaultTextColor(text_color)
         for port, text in self._output_items.items():
             text.setDefaultTextColor(text_color)
-        self._text_item.setDefaultTextColor(text_color)
+        self.text_item.setDefaultTextColor(text_color)
 
     def activate_pipes(self):
         """
@@ -299,8 +300,8 @@ def calc_size(self, add_w=0.0, add_h=0.0):
             add_w (float): additional width.
             add_h (float): additional height.
         """
-        width = self._text_item.boundingRect().width()
-        height = self._text_item.boundingRect().height()
+        width = 0
+        height = 0
 
         if self._widgets:
             wid_width = max([
@@ -366,11 +367,11 @@ def arrange_label(self, h_offset=0.0, v_offset=0.0):
             v_offset (float): vertical offset.
             h_offset (float): horizontal offset.
         """
-        text_rect = self._text_item.boundingRect()
+        text_rect = self.text_item.boundingRect()
         text_x = (self._width / 2) - (text_rect.width() / 2)
         text_x += h_offset
-        text_y = 1.0 + v_offset
-        self._text_item.setPos(text_x, text_y)
+        text_y = v_offset - 25
+        self.text_item.setPos(text_x, text_y)
 
     def arrange_widgets(self, v_offset=0.0):
         """
@@ -444,15 +445,15 @@ def offset_label(self, x=0.0, y=0.0):
             x (float): horizontal x offset
             y (float): vertical y offset
         """
-        icon_x = self._text_item.pos().x() + x
-        icon_y = self._text_item.pos().y() + y
-        self._text_item.setPos(icon_x, icon_y)
+        icon_x = self.text_item.pos().x() + x
+        icon_y = self.text_item.pos().y() + y
+        self.text_item.setPos(icon_x, icon_y)
 
     def draw_node(self):
         """
         Draw the node item in the scene.
         """
-        height = self._text_item.boundingRect().height()
+        height = self.text_item.boundingRect().height()
         # setup initial base size.
         self._set_base_size(add_w=0.0, add_h=height)
         # set text color when node is initialized.
@@ -520,7 +521,7 @@ def set_proxy_mode(self, mode):
             # for pipe in port.connected_pipes:
             #     pipe.setVisible(visible)
 
-        self._text_item.setVisible(visible)
+        self.text_item.setVisible(visible)
         self._icon_item.setVisible(visible)
 
     @property
@@ -571,9 +572,9 @@ def selected(self, selected=False):
     @AbstractNodeItem.name.setter
     def name(self, name=''):
         AbstractNodeItem.name.fset(self, name)
-        self._text_item.setPlainText(name)
+        self.text_item.setPlainText(name)
         if self.scene():
-            self.draw_node()
+            self.arrange_label()
         self.update()
 
     @AbstractNodeItem.color.setter

NodeGraphQt/qgraphics/text_item.py

@@ -0,0 +1,31 @@
+from PySide2 import QtWidgets, QtGui, QtCore
+
+
+class text_item(QtWidgets.QGraphicsTextItem):
+    editingFinished = QtCore.Signal(str)
+
+    def __init__(self, text, parent=None):
+        super(text_item, self).__init__(text, parent)
+        self.setFlags(QtWidgets.QGraphicsItem.ItemIsFocusable)
+        self.setTextInteractionFlags(QtGui.Qt.NoTextInteraction)
+        self.isEditing = False
+
+    def _editingFinished(self):
+        if self.isEditing:
+            self.setTextInteractionFlags(QtGui.Qt.NoTextInteraction)
+            self.isEditing = False
+            self.editingFinished.emit(self.toPlainText())
+
+    def mousePressEvent(self, event):
+        self.setTextInteractionFlags(QtGui.Qt.TextEditable)
+        self.isEditing = True
+        super(text_item, self).mousePressEvent(event)
+
+    def focusOutEvent(self, event):
+        self._editingFinished()
+        super(text_item, self).focusOutEvent(event)
+
+    def keyPressEvent(self, event):
+        if event.key() is QtGui.Qt.Key_Return:
+            self._editingFinished()
+        super(text_item, self).keyPressEvent(event)