addition updates:

 - pep8 cleanup.
 - updated insert node logic.
 - added some doc strings.

Author: jchanvfx

NodeGraphQt/base/graph.py

@@ -12,7 +12,7 @@
 from NodeGraphQt.base.factory import NodeFactory
 from NodeGraphQt.base.menu import NodeGraphMenu, NodesMenu
 from NodeGraphQt.base.model import NodeGraphModel
-from NodeGraphQt.base.node import NodeObject,BaseNode
+from NodeGraphQt.base.node import NodeObject
 from NodeGraphQt.base.port import Port
 from NodeGraphQt.constants import (DRAG_DROP_ID,
                                    PIPE_LAYOUT_CURVED,
@@ -121,21 +121,31 @@ def _wire_signals(self):
         self._viewer.node_selected.connect(self._on_node_selected)
         self._viewer.data_dropped.connect(self._on_node_data_dropped)
 
-    def _insert_node(self, items):
-        pipe = items[0]
-        node = self.get_node_by_id(items[1])
-        if not isinstance(node,BaseNode):
-            return
+    def _insert_node(self, pipe, node_id, prev_node_pos):
+        """
+        Slot function triggered when a selected node has collided with a pipe.
+
+        Args:
+            pipe (Pipe): collided pipe item.
+            node_id (str): selected node id to insert.
+            prev_node_pos (dict): previous node position. {NodeItem: [prev_x, prev_y]}
+        """
+        node = self.get_node_by_id(node_id)
 
         disconnected = [(pipe.input_port, pipe.output_port)]
         connected = []
 
         if node.inputs():
-            connected.append((pipe.output_port, list(node.inputs().values())[0].view))
+            connected.append(
+                (pipe.output_port, list(node.inputs().values())[0].view)
+            )
         if node.outputs():
-            connected.append((list(node.outputs().values())[0].view, pipe.input_port))
+            connected.append((node.output(0).view, pipe.input_port))
 
+        self._undo_stack.beginMacro('inserted node')
         self._on_connection_changed(disconnected, connected)
+        self._on_nodes_moved(prev_node_pos)
+        self._undo_stack.endMacro()
 
     def _toggle_tab_search(self):
         """

NodeGraphQt/base/node.py

@@ -529,7 +529,7 @@ def add_text_input(self, name, label='', text='', tab=None):
         widget.value_changed.connect(lambda k, v: self.set_property(k, v))
         self.view.add_widget(widget)
 
-    def add_float_input(self, name, label='', value=0, tab=None):
+    def add_float_input(self, name, label='', value=0.0, tab=None):
         """
         Creates a custom property with the :meth:`NodeObject.create_property`
         function and embeds a :class:`PySide2.QtWidgets.QLineEdit` widget

NodeGraphQt/qgraphics/pipe.py

@@ -27,6 +27,7 @@ def __init__(self, input_port=None, output_port=None):
         super(Pipe, self).__init__()
         self.setZValue(Z_VAL_PIPE)
         self.setAcceptHoverEvents(True)
+        self.setFlag(QtWidgets.QGraphicsItem.ItemIsSelectable)
         self._color = PIPE_DEFAULT_COLOR
         self._style = PIPE_STYLE_DEFAULT
         self._active = False
@@ -38,7 +39,6 @@ def __init__(self, input_port=None, output_port=None):
         self._arrow.append(QtCore.QPointF(-size, size))
         self._arrow.append(QtCore.QPointF(0.0, -size * 1.5))
         self._arrow.append(QtCore.QPointF(size, size))
-        self.setFlag(QtWidgets.QGraphicsItem.ItemIsSelectable)
 
     def __repr__(self):
         in_name = self._input_port.name if self._input_port else ''

NodeGraphQt/widgets/node_property.py

@@ -1,5 +1,5 @@
 #!/usr/bin/python
-from NodeGraphQt import QtCore, QtWidgets
+from NodeGraphQt import QtCore, QtWidgets, QtGui
 
 from NodeGraphQt.constants import Z_VAL_NODE_WIDGET
 from NodeGraphQt.widgets.stylesheet import *
@@ -251,72 +251,39 @@ def value(self, text=''):
             self._ledit.setText(text)
             self._value_changed()
 
+
 class NodeFloatEdit(NodeLineEdit):
     """
-    NodeFloatEdit widget is subclassed from :class:`NodeBaseWidget`,
+    NodeFloatEdit widget is subclassed from :class:`NodeLineEdit`,
     this widget is displayed as a ``QLineEdit`` embedded in a node.
 
     .. note::
         `To embed a ``QLineEdit`` in a node see func:`
         :meth:`NodeGraphQt.BaseNode.add_float_input`
     """
 
-    def __init__(self, parent=None, name='', label='', value=0):
+    def __init__(self, parent=None, name='', label='', value=0.0):
         super(NodeFloatEdit, self).__init__(parent, name, label)
-        self.text = self._convertValue(value)
-        self._ledit = QtWidgets.QLineEdit(self.text)
-        self._ledit.setStyleSheet(STYLE_QLINEEDIT)
-        self._ledit.setAlignment(QtCore.Qt.AlignCenter)
-        self._ledit.editingFinished.connect(lambda:self._editFinished())
-        self._ledit.clearFocus()
-        group = _NodeGroupBox(label)
-        group.add_node_widget(self._ledit)
-        group.setMaximumWidth(120)
-        self.setWidget(group)
-
-
-    def _convertValue(self,value):
-        if type(value) == float or type(value) == int:
-            return str(value)
-        elif type(value) == str:
-            if value.replace(".", "").isdigit():
-                if len(value.split(".")) > 2:
-                    return "0"
-                return value
-            else:
-                return "0"
-        else:
-            return "0"
-
-    def _setValue(self,value):
-        self._ledit.setText(self._convertValue(value))
-        self._value_changed()
-
-    def _editFinished(self):
-        self._setValue(self._ledit.text())
-
-    @property
-    def type_(self):
-        return 'FloatEditNodeWidget'
+        regex = '\\d+|\\d+\\.\\d+'
+        validator = QtGui.QRegExpValidator(regex, self._ledit)
+        self._ledit.setValidator(validator)
+        self.text = str(value)
 
     @property
     def value(self):
         """
-        Returns the widgets current text.
+        Returns the widgets current float value.
 
         Returns:
-            float: current value.
+            float: float value.
         """
-        text = self._ledit.text()
-        if text:
-            return float(self._ledit.text())
-        else:
-            return 0
+        return float(self._ledit.text() or '0')
 
     @value.setter
-    def value(self, value=0):
-        if value != self.value:
-            self._setValue(value)
+    def value(self, text=0.0):
+        if text != self.value:
+            self._ledit.setText(str(text))
+            self._value_changed()
 
 
 class NodeCheckBox(NodeBaseWidget):