Skip to content

Commit 3bf46d0

Browse files
jchanvfxArnoChenFx
authored andcommitted
minor bug fix.
1 parent 3541edb commit 3bf46d0

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

NodeGraphQt/base/graph.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class NodeGraph(QtCore.QObject):
9696
9797
:parameters: list[:class:`NodeGraphQt.NodeObject`],
9898
list[:class:`NodeGraphQt.NodeObject`]
99-
:emits: previous node selection, new selection.
99+
:emits: selected node, deselected nodes.
100100
"""
101101
node_double_clicked = QtCore.Signal(NodeObject)
102102
"""
@@ -270,18 +270,18 @@ def _on_node_selected(self, node_id):
270270
node = self.get_node_by_id(node_id)
271271
self.node_selected.emit(node)
272272

273-
def _on_node_selection_changed(self, prev_ids, node_ids):
273+
def _on_node_selection_changed(self, sel_ids, desel_ids):
274274
"""
275275
called when the node selection changes in the viewer.
276-
(emits node objects <un-selected nodes>, <selected nodes>)
276+
(emits node objects <deselected nodes>, <selected nodes>)
277277
278278
Args:
279-
prev_ids (list[str]): previous selection.
280-
node_ids (list[str]): current selection.
279+
sel_ids (list[str]): new selected node ids.
280+
desel_ids (list[str]): deselected node ids.
281281
"""
282-
prev_nodes = [self.get_node_by_id(nid) for nid in prev_ids]
283-
new_nodes = [self.get_node_by_id(nid) for nid in node_ids]
284-
self.node_selection_changed.emit(prev_nodes, new_nodes)
282+
sel_nodes = [self.get_node_by_id(nid) for nid in sel_ids]
283+
unsel_nodes = [self.get_node_by_id(nid) for nid in desel_ids]
284+
self.node_selection_changed.emit(sel_nodes, unsel_nodes)
285285

286286
def _on_node_data_dropped(self, data, pos):
287287
"""

NodeGraphQt/widgets/viewer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ def mouseReleaseEvent(self, event):
322322
if not n.selected
323323
]
324324
self.node_selected.emit(node_ids[0])
325-
self.node_selection_changed.emit(prev_ids, node_ids)
325+
self.node_selection_changed.emit(node_ids, prev_ids)
326326

327327
self.scene().update(map_rect)
328328
return
@@ -349,7 +349,7 @@ def mouseReleaseEvent(self, event):
349349
# emit node selection changed signal.
350350
prev_ids = [n.id for n in self._prev_selection_nodes if not n.selected]
351351
node_ids = [n.id for n in nodes if n not in self._prev_selection_nodes]
352-
self.node_selection_changed.emit(prev_ids, node_ids)
352+
self.node_selection_changed.emit(node_ids, prev_ids)
353353

354354
super(NodeViewer, self).mouseReleaseEvent(event)
355355

0 commit comments

Comments
 (0)