Skip to content

Commit 842a2bf

Browse files
committed
clean up
1 parent 6a0c10c commit 842a2bf

File tree

6 files changed

+23
-28
lines changed

6 files changed

+23
-28
lines changed

NodeGraphQt/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@
5151

5252
from .base.actions import setup_context_menu
5353
from .base.graph import NodeGraph
54-
from .base.node import NodeObject, BaseNode, Backdrop
54+
from .base.node import NodeObject, BaseNode, BackdropNode
5555
from .base.port import Port
5656
from .base.menu import Menu, MenuCommand

NodeGraphQt/base/graph.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from NodeGraphQt.base.node import NodeObject
1616
from NodeGraphQt.base.port import Port
1717
from NodeGraphQt.constants import DRAG_DROP_ID
18-
from NodeGraphQt.widgets.node_list import NodeListWidget
18+
from NodeGraphQt.widgets.node_tree import NodeTreeWidget
1919
from NodeGraphQt.widgets.properties_bin import PropertiesBinWidget
2020
from NodeGraphQt.widgets.viewer import NodeViewer
2121

@@ -254,10 +254,10 @@ def nodes_list(self):
254254
Initializes the nodes list widget when first called.
255255
256256
Returns:
257-
NodeListWidget: the initialized widget.
257+
NodeTreeWidget: the initialized widget.
258258
"""
259259
if self._nodes_list is None:
260-
self._nodes_list = NodeListWidget()
260+
self._nodes_list = NodeTreeWidget()
261261
self._nodes_list.set_node_factory(self._node_factory)
262262
return self._nodes_list
263263

NodeGraphQt/base/node.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -562,15 +562,15 @@ def set_output(self, index, port):
562562
src_port.connect_to(port)
563563

564564

565-
class Backdrop(NodeObject):
565+
class BackdropNode(NodeObject):
566566
"""
567567
base class of a Backdrop node.
568568
"""
569569

570570
NODE_NAME = 'Backdrop'
571571

572572
def __init__(self):
573-
super(Backdrop, self).__init__(BackdropNodeItem())
573+
super(BackdropNode, self).__init__(BackdropNodeItem())
574574
# override base default color.
575575
self.model.color = (5, 129, 138, 255)
576576
self.create_property('bg_text', '')

NodeGraphQt/widgets/node_list.py renamed to NodeGraphQt/widgets/node_tree.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,24 @@
88
TYPE_CATEGORY = QtWidgets.QTreeWidgetItem.UserType + 2
99

1010

11-
class BaseListWidgetItem(QtWidgets.QListWidgetItem):
11+
class BaseNodeTreeItem(QtWidgets.QTreeWidgetItem):
1212

1313
def __eq__(self, other):
1414
return id(self) == id(other)
1515

1616

17-
class NodeListWidget(QtWidgets.QTreeWidget):
17+
class NodeTreeWidget(QtWidgets.QTreeWidget):
1818

1919
def __init__(self, parent=None):
20-
super(NodeListWidget, self).__init__(parent)
20+
super(NodeTreeWidget, self).__init__(parent)
2121
self.setDragDropMode(QtWidgets.QAbstractItemView.DragOnly)
2222
self.setHeaderHidden(True)
2323
self._factory = None
2424
self._custom_labels = {}
2525

2626
def mimeData(self, items):
2727
node_ids = ','.join(i.toolTip(0) for i in items)
28-
mime_data = super(NodeListWidget, self).mimeData(items)
28+
mime_data = super(NodeTreeWidget, self).mimeData(items)
2929
mime_data.setText('<${}>:{}'.format(DRAG_DROP_ID, node_ids))
3030
return mime_data
3131

@@ -47,9 +47,7 @@ def _build_tree(self):
4747
label = self._custom_labels[category]
4848
else:
4949
label = '- {}'.format(category)
50-
cat_item = QtWidgets.QTreeWidgetItem(
51-
self, [label], type=TYPE_CATEGORY
52-
)
50+
cat_item = BaseNodeTreeItem(self, [label], type=TYPE_CATEGORY)
5351
cat_item.setFirstColumnSpanned(True)
5452
cat_item.setFlags(QtCore.Qt.ItemIsEnabled)
5553
self.addTopLevelItem(cat_item)
@@ -60,14 +58,11 @@ def _build_tree(self):
6058
category = '.'.join(node_id.split('.')[:-1])
6159
category_item = category_items[category]
6260

63-
item = QtWidgets.QTreeWidgetItem(
64-
category_item, [node_name], type=TYPE_NODE
65-
)
61+
item = BaseNodeTreeItem(category_item, [node_name], type=TYPE_NODE)
6662
item.setToolTip(0, node_id)
6763

6864
category_item.addChild(item)
6965

70-
7166
def set_node_factory(self, factory):
7267
"""
7368
Set current node factory.

docs/nodes.rst

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ Nodes
22
*****
33

44

5-
Node Object
6-
===========
5+
Object
6+
======
77

8-
**Inherited by:** :class:`NodeGraphQt.BaseNode`, :class:`NodeGraphQt.Backdrop`
8+
**Inherited by:** :class:`NodeGraphQt.BaseNode`, :class:`NodeGraphQt.BackdropNode`
99

1010
The ``NodeObject`` class is the main base class that all nodes inherit from.
1111

@@ -25,8 +25,8 @@ The ``NodeObject`` class is the main base class that all nodes inherit from.
2525
:exclude-members: model, NODE_NAME
2626

2727

28-
Base Node
29-
=========
28+
Node
29+
====
3030

3131
**Inherited from:** :class:`NodeGraphQt.NodeObject`
3232

@@ -43,18 +43,18 @@ The ``BaseNode`` class is the base class for nodes that allows port connections
4343
:exclude-members: update_model
4444

4545

46-
Backdrop Node
47-
=============
46+
Backdrop
47+
========
4848

4949
**Inherited from:** :class:`NodeGraphQt.NodeObject`
5050

51-
The ``Backdrop`` class allows other node object to be nested inside, it's mainly good for grouping nodes together.
51+
The ``BackdropNode`` class allows other node object to be nested inside, it's mainly good for grouping nodes together.
5252

5353
.. image:: _images/backdrop.png
5454
:width: 250px
5555

5656
----
5757

58-
.. autoclass:: NodeGraphQt.Backdrop
58+
.. autoclass:: NodeGraphQt.BackdropNode
5959
:members:
6060

example.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import os
44
import sys
55

6-
from NodeGraphQt import NodeGraph, BaseNode, Backdrop, setup_context_menu
6+
from NodeGraphQt import NodeGraph, BaseNode, BackdropNode, setup_context_menu
77
from NodeGraphQt import QtWidgets, QtCore
88

99
# import example nodes from the "example_nodes" package
@@ -65,7 +65,7 @@ def show_nodes_list(node):
6565

6666
# registered nodes.
6767
reg_nodes = [
68-
Backdrop, MyNode,
68+
BackdropNode, MyNode,
6969
basic_nodes.FooNode,
7070
basic_nodes.BarNode,
7171
widget_nodes.DropdownMenuNode,

0 commit comments

Comments
 (0)