Skip to content

Commit b109ef8

Browse files
committed
doc string clean up
1 parent dfe4e9f commit b109ef8

File tree

3 files changed

+29
-13
lines changed

3 files changed

+29
-13
lines changed

NodeGraphQt/base/graph.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,6 +2189,18 @@ def node(self):
21892189
return self._node
21902190

21912191
def delete_node(self, node, push_undo=True):
2192+
"""
2193+
Remove the node from the node sub graph.
2194+
2195+
Note:
2196+
:class:`.PortInputNode` & :class:`.PortOutputNode` can't be deleted
2197+
as they are connected to a :class:`.Port` to remove these port nodes
2198+
see :meth:`BaseNode.delete_input`, :meth:`BaseNode.delete_output`.
2199+
2200+
Args:
2201+
node (NodeGraphQt.BaseNode): node object.
2202+
push_undo (bool): register the command to the undo stack. (default: True)
2203+
"""
21922204
port_nodes = self.get_input_port_nodes() + self.get_output_port_nodes()
21932205
if node in port_nodes and node.parent_port is not None:
21942206
# note: port nodes can only be deleted by deleting the parent

NodeGraphQt/nodes/base_node.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,9 @@ def delete_input(self, port):
351351
Warnings:
352352
Undo is NOT supported for this function.
353353
354-
You can only delete ports if the node has "ports_removable"
355-
enabled see :meth:`BaseNode.set_ports_removable`.
354+
You can only delete ports if :meth:`BaseNode.port_deletion_allowed`
355+
returns ``True`` otherwise a port error is raised see also
356+
:meth:`BaseNode.set_port_deletion_allowed`.
356357
357358
Args:
358359
port (str or int): port name or index.
@@ -380,8 +381,9 @@ def delete_output(self, port):
380381
Warnings:
381382
Undo is NOT supported for this function.
382383
383-
You can only delete ports if the node has "ports_removable"
384-
enabled see :meth:`BaseNode.set_ports_removable`.
384+
You can only delete ports if :meth:`BaseNode.port_deletion_allowed`
385+
returns ``True`` otherwise a port error is raised see also
386+
:meth:`BaseNode.set_port_deletion_allowed`.
385387
386388
Args:
387389
port (str or int): port name or index.
@@ -407,7 +409,8 @@ def set_port_deletion_allowed(self, mode=False):
407409
Allow ports to be removable on this node.
408410
409411
See Also:
410-
:meth:`BaseNode.ports_removable`
412+
:meth:`BaseNode.port_deletion_allowed` and
413+
:meth:`BaseNode.set_ports`
411414
412415
Args:
413416
mode (bool): true to allow.
@@ -419,7 +422,7 @@ def port_deletion_allowed(self):
419422
Return true if ports can be deleted on this node.
420423
421424
See Also:
422-
:meth:`BaseNode.set_ports_removable`
425+
:meth:`BaseNode.set_port_deletion_allowed`
423426
424427
Returns:
425428
bool: true if ports can be deleted.
@@ -432,7 +435,8 @@ def set_ports(self, port_data):
432435
433436
Warnings:
434437
You can only use this function if the node has
435-
"ports_removable" enabled see :meth:`BaseNode.set_ports_removable`
438+
:meth:`BaseNode.port_deletion_allowed` is `True`
439+
see :meth:`BaseNode.set_port_deletion_allowed`
436440
437441
Hint:
438442
example snippet of port data.
@@ -446,15 +450,13 @@ def set_ports(self, port_data):
446450
'name': 'input',
447451
'multi_connection': True,
448452
'display_name': 'Input',
449-
'data_type': 'NoneType',
450453
'locked': False
451454
}],
452455
'output_ports':
453456
[{
454457
'name': 'output',
455458
'multi_connection': True,
456459
'display_name': 'Output',
457-
'data_type': 'NoneType',
458460
'locked': False
459461
}]
460462
}
@@ -465,7 +467,7 @@ def set_ports(self, port_data):
465467
if not self.port_deletion_allowed():
466468
raise PortError(
467469
'Ports cannot be set on this node because '
468-
'"ports_removable" is not enabled on this node.')
470+
'"set_port_deletion_allowed" is not enabled on this node.')
469471

470472
for port in self._inputs:
471473
self._view.delete_input(port.view)
@@ -480,11 +482,13 @@ def set_ports(self, port_data):
480482

481483
[self.add_input(name=port['name'],
482484
multi_input=port['multi_connection'],
483-
display_name=port['display_name'])
485+
display_name=port['display_name'],
486+
locked=port.get('locked') or False)
484487
for port in port_data['input_ports']]
485488
[self.add_output(name=port['name'],
486489
multi_output=port['multi_connection'],
487-
display_name=port['display_name'])
490+
display_name=port['display_name'],
491+
locked=port.get('locked') or False)
488492
for port in port_data['output_ports']]
489493
self.draw()
490494

docs/graph.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ SubGraph
2020

2121
.. autoclass:: NodeGraphQt.SubGraph
2222
:members:
23-
:exclude-members: delete_node, is_root, sub_graphs, widget
23+
:exclude-members: is_root, sub_graphs, widget

0 commit comments

Comments
 (0)