Skip to content

Commit 5e51dbc

Browse files
smortexbastelfreak
authored andcommitted
Consider Java 21 "supported"
Use the same Java configuration as with the previous LTS version, Java 17.
1 parent 162600a commit 5e51dbc

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

project.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@
137137
(throw unsupported-ex))
138138
11 ["-Djava.security.properties==./dev-resources/java.security.jdk11on-fips"]
139139
17 ["-Djava.security.properties==./dev-resources/java.security.jdk11on-fips"]
140+
21 ["-Djava.security.properties==./dev-resources/java.security.jdk11on-fips"]
140141
(do)))}
141142
:fips [:defaults :fips-deps]
142143

@@ -249,7 +250,7 @@
249250
(str "-Xms" (heap-size "1G"))
250251
(str "-Xmx" (heap-size "2G"))
251252
"-XX:+IgnoreUnrecognizedVMOptions"]
252-
(if (= 17 (java.lang.Integer/parseInt major))
253+
(if (>= 17 (java.lang.Integer/parseInt major))
253254
["--add-opens" "java.base/sun.nio.ch=ALL-UNNAMED" "--add-opens" "java.base/java.io=ALL-UNNAMED"]
254255
[])))
255256

resources/ext/cli_defaults/cli-defaults.sh.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ fi
77
java_version=$($JAVA_BIN -version 2>&1 | head -1 | awk -F\" '{ print $2 }')
88
java_major_version=$(echo $java_version | awk -F. '{ print $1 }')
99

10-
if [[ $java_major_version -eq 17 ]]; then
10+
if [[ $java_major_version -ge 17 ]]; then
1111

1212
echo $JAVA_ARGS | grep "add-opens" &>/dev/null
1313
if [[ 0 -ne $? ]]; then

src/clj/puppetlabs/services/master/master_service.clj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,16 @@
8383
(re-matches #"1\.[1234567]($|(\..*))" version) :unsupported
8484
(re-matches #"1\.[89]($|(\..*))" version) :deprecated
8585
(re-matches #"10($|(\..*))" version) :deprecated
86-
(re-matches (re-pattern (str 11 "($|(\\..*))")) version) :official
86+
(re-matches #"11($|(\..*))" version) :official
8787
(re-matches #"17($|(\..*))" version) :official
88+
(re-matches #"21($|(\..*))" version) :official
8889
:else :unknown))
8990

9091
(defn log-java-deprecation-message [version]
9192
(let [status (jdk-support-status version)]
9293
(case status
93-
(:unknown) (log/warn (i18n/trs "JDK {0} is neither tested nor supported. Please use JDK 11 or 17" version))
94-
(:deprecated) (log/warn (i18n/trs "JDK {0} is deprecated, please upgrade to JDK 11 or 17" version))
94+
(:unknown) (log/warn (i18n/trs "JDK {0} is neither tested nor supported. Please use JDK 11, 17 or 21" version))
95+
(:deprecated) (log/warn (i18n/trs "JDK {0} is deprecated, please upgrade to JDK 11, 17 or 21" version))
9596
(:official) nil
9697
(:unsupported) (log/warn (i18n/trs "Puppetserver doesn't support JDK {0}" version)))))
9798

test/unit/puppetlabs/services/master/master_core_test.clj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,10 @@
469469
(is (= :official (master-service/jdk-support-status "11.0")))
470470
(is (= :official (master-service/jdk-support-status "11.0.7")))
471471
(is (= :official (master-service/jdk-support-status "17.0")))
472-
(is (= :official (master-service/jdk-support-status "17.0.4"))))
472+
(is (= :official (master-service/jdk-support-status "17.0.4")))
473+
(is (= :official (master-service/jdk-support-status "21")))
474+
(is (= :official (master-service/jdk-support-status "21.0")))
475+
(is (= :official (master-service/jdk-support-status "21.0.8"))))
473476

474477
(deftest v4-routes-test
475478
(with-redefs [jruby-core/borrow-from-pool-with-timeout (fn [_ _ _] {:jruby-puppet (Object.)})

0 commit comments

Comments
 (0)