-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
Time has passed and now it should be trivially possible to fix our broken reliance on pointers not moving, as runtime.Pin eventually did arrive in Go 1.21.
https://github.com/jchv/go-webview2/blob/master/pkg/edge/chromium.go#L49-L59
We probably just need one pinner for all of the handlers. One open question is when to execute the unpin; a finalizer might be the safest bet. (In the future, it may be done more efficiently using runtime.AddCleanup, but doing that would require depending on Go 1.24.0 or higher, which is not desirable yet.)
I'm considering this a bug since the code is relying on behavior that is explicitly not guaranteed.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers