Fix some incorrect diagnostic messages

Author: Sergio0694

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Diagnostics/Analyzers/UseGeneratedDependencyPropertyOnManualPropertyAnalyzer.cs

@@ -431,9 +431,6 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                         fieldFlags.PropertyTypeExpressionLocation = propertyTypeArgument.Syntax.GetLocation();
                     }
 
-                    // Best effort name to use to interpolate any diagnostics below to emit if the default value is not valid
-                    string propertyNameForMessageFormat = "___";
-
                     // We cannot validate the property name from here yet, but let's check it's a constant, and save it for later
                     if (nameArgument.Value.ConstantValue is { HasValue: true, Value: string propertyName })
                     {
@@ -442,8 +439,6 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                             fieldFlags.PropertyName = propertyName;
                         }
 
-                        propertyNameForMessageFormat = propertyName;
-
                         // Additional diagnostic #2: the property name should be the same as the field name, without the "Property" suffix (as per convention)
                         if (fieldSymbol.Name.EndsWith("Property") && propertyName != fieldSymbol.Name[..^"Property".Length])
                         {
@@ -555,8 +550,7 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                                     InvalidDefaultValueNullOnDependencyPropertyField,
                                     defaultValueArgument.Syntax.GetLocation(),
                                     fieldSymbol,
-                                    propertyTypeSymbol,
-                                    propertyNameForMessageFormat));
+                                    propertyTypeSymbol));
                             }
                         }
                         else
@@ -592,8 +586,7 @@ void HandleSetAccessor(IPropertySymbol propertySymbol, PropertyFlags propertyFla
                                         defaultValueArgument.Syntax.GetLocation(),
                                         fieldSymbol,
                                         operandTypeSymbol,
-                                        propertyTypeSymbol,
-                                        propertyNameForMessageFormat));
+                                        propertyTypeSymbol));
                                 }
                             }
                         }

components/DependencyPropertyGenerator/CommunityToolkit.DependencyPropertyGenerator.SourceGenerators/Diagnostics/DiagnosticDescriptors.cs

@@ -422,28 +422,28 @@ internal static class DiagnosticDescriptors
         helpLinkUri: "https://aka.ms/toolkit/labs/windows");
 
     /// <summary>
-    /// <c>The field '{0}' is registering a dependency property, but its default value is set to 'null', which is not compatible with the property type '{1}' declared in metadata (consider changing the default value, implementing the 'On{2}Get(ref object)' partial method to handle the type mismatch, or suppressing the diagnostic if this is the intended behavior)</c>.
+    /// <c>The field '{0}' is registering a dependency property, but its default value is set to 'null', which is not compatible with the property type '{1}' declared in metadata (consider changing the default value, setting the property value to a non 'null' value upon object construction, and/or suppressing the diagnostic if this is the intended behavior)</c>.
     /// </summary>
     public static readonly DiagnosticDescriptor InvalidDefaultValueNullOnDependencyPropertyField = new(
         id: "WCTDPG0031",
         title: "Invalid 'null' default value in dependency property field metadata",
-        messageFormat: "The field '{0}' is registering a dependency property, but its default value is set to 'null', which is not compatible with the property type '{1}' declared in metadata (consider changing the default value, implementing the 'On{2}Get(ref object)' partial method to handle the type mismatch, or suppressing the diagnostic if this is the intended behavior)",
+        messageFormat: "The field '{0}' is registering a dependency property, but its default value is set to 'null', which is not compatible with the property type '{1}' declared in metadata (consider changing the default value, setting the property value to a non 'null' value upon object construction, and/or suppressing the diagnostic if this is the intended behavior)",
         category: DiagnosticCategory,
         defaultSeverity: DiagnosticSeverity.Warning,
         isEnabledByDefault: true,
-        description: "All dependency property fields setting an explicit default value in metadata should do so with an expression of a type comparible with the property type. Alternatively, the generated getter method (eg. 'OnNameGet', if the property is called 'Name') should be implemented to handle the type mismatch.",
+        description: "All dependency property fields setting an explicit default value in metadata should do so with an expression of a type comparible with the property type. Alternatively, the property value should be set to a non 'null' value upon object construction.",
         helpLinkUri: "https://aka.ms/toolkit/labs/windows");
 
     /// <summary>
-    /// <c>The field '{0}' is registering a dependency property, but its default value has type '{1}', which is not compatible with the property type '{2}' declared in metadata (consider fixing the default value, or implementing the 'On{3}Get(ref object)' partial method to handle the type mismatch)</c>.
+    /// <c>The field '{0}' is registering a dependency property, but its default value has type '{1}', which is not compatible with the property type '{2}' declared in metadata (consider fixing the default value, or suppressing the diagnostic if this is the intended behavior)</c>.
     /// </summary>
     public static readonly DiagnosticDescriptor InvalidDefaultValueTypeOnDependencyPropertyField = new(
         id: "WCTDPG0032",
         title: "Invalid default value type in dependency property field metadata",
-        messageFormat: "The field '{0}' is registering a dependency property, but its default value has type '{1}', which is not compatible with the property type '{2}' declared in metadata (consider fixing the default value, or implementing the 'On{3}Get(ref object)' partial method to handle the type mismatch)",
+        messageFormat: "The field '{0}' is registering a dependency property, but its default value has type '{1}', which is not compatible with the property type '{2}' declared in metadata (consider fixing the default value, or suppressing the diagnostic if this is the intended behavior)",
         category: DiagnosticCategory,
         defaultSeverity: DiagnosticSeverity.Warning,
         isEnabledByDefault: true,
-        description: "All dependency property fields setting an explicit default value in metadata should do so with an expression of a type comparible with the property type. Alternatively, the generated getter method (eg. 'OnNameGet', if the property is called 'Name') should be implemented to handle the type mismatch.",
+        description: "All dependency property fields setting an explicit default value in metadata should do so with an expression of a type comparible with the property type.",
         helpLinkUri: "https://aka.ms/toolkit/labs/windows");
 }