Fix all golangci-lint errors (17 issues resolved)

Resolved 9 errcheck, 3 staticcheck, and 5 unused code issues:

- Add proper error handling for all file/resource close operations
- Use defer functions with slog.Warn/Debug for cleanup errors
- Remove deprecated lipgloss Copy() method calls
- Remove unused TUI message types and color constants
- Refactor generate loop to use closure for proper defer scoping
- Replace if-else with switch in parser test for code clarity
- Add explicit error ignoring for best-effort cleanup operations

All tests pass and build succeeds.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: jcrussell

pkg/analysis/history.go

@@ -210,7 +210,9 @@ func calculateDistances(cfg *config.Config, data *ccda.Data, encounters []ccda.E
 		slog.Debug("added final return trip home", "distance_km", returnDistance)
 	}
 
-	geocoder.SaveCache()
+	if err := geocoder.SaveCache(); err != nil {
+		slog.Debug("failed to save geocoding cache", "error", err)
+	}
 	return totalDistance
 }
 

pkg/ccda/parser.go

@@ -76,7 +76,11 @@ func ExtractAndParse(zipPath string) (*Data, error) {
 	if err != nil {
 		return nil, fmt.Errorf("failed to open zip: %w", err)
 	}
-	defer r.Close()
+	defer func() {
+		if err := r.Close(); err != nil {
+			slog.Warn("failed to close zip reader", "error", err)
+		}
+	}()
 
 	data := &Data{
 		Encounters:    []Encounter{},
@@ -110,7 +114,9 @@ func ExtractAndParse(zipPath string) (*Data, error) {
 			}
 
 			fileBytes, err := io.ReadAll(rc)
-			rc.Close()
+			if closeErr := rc.Close(); closeErr != nil {
+				slog.Warn("failed to close METADATA.xml", "error", closeErr)
+			}
 			if err != nil {
 				slog.Error("error reading METADATA.xml", "error", err)
 				continue
@@ -144,7 +150,9 @@ func ExtractAndParse(zipPath string) (*Data, error) {
 
 			// Read entire file content first to help with decryption issues
 			fileBytes, err := io.ReadAll(rc)
-			rc.Close()
+			if closeErr := rc.Close(); closeErr != nil {
+				slog.Warn("failed to close XML file", "name", f.Name, "error", closeErr)
+			}
 			if err != nil {
 				slog.Error("error reading file", "name", f.Name, "error", err)
 				continue

pkg/ccda/parser_test.go

@@ -399,9 +399,10 @@ func TestParseSingleFile_Vitals(t *testing.T) {
 	// Find BP and weight
 	var bp, weight *Vital
 	for i := range data.Vitals {
-		if data.Vitals[i].LOINCCode == "8480-6" {
+		switch data.Vitals[i].LOINCCode {
+		case "8480-6":
 			bp = &data.Vitals[i]
-		} else if data.Vitals[i].LOINCCode == "29463-7" {
+		case "29463-7":
 			weight = &data.Vitals[i]
 		}
 	}

pkg/cmd/generate/generate.go

@@ -181,33 +181,40 @@ func runGenerate(opts *GenerateOptions) error {
 		filename := p.Filename()
 		fmt.Printf("📝 Generating %s...\n", filename)
 
-		f, err := os.Create(filepath.Join(opts.OutputDir, filename))
-		if err != nil {
-			return err
-		}
-		defer f.Close()
+		// Wrap in closure to ensure proper defer scoping in loop
+		if err := func() error {
+			f, err := os.Create(filepath.Join(opts.OutputDir, filename))
+			if err != nil {
+				return err
+			}
+			defer func() {
+				if err := f.Close(); err != nil {
+					slog.Warn("failed to close output file", "filename", filename, "error", err)
+				}
+			}()
 
-		// Clone the main layout and parse the specific page content
-		pageTmpl, err := mainTmpl.Clone()
-		if err != nil {
-			return fmt.Errorf("failed to clone template: %w", err)
-		}
-		_, err = pageTmpl.New("content").Funcs(funcMap).Parse(p.Template())
-		if err != nil {
-			return fmt.Errorf("failed to parse page template: %w", err)
-		}
+			// Clone the main layout and parse the specific page content
+			pageTmpl, err := mainTmpl.Clone()
+			if err != nil {
+				return fmt.Errorf("failed to clone template: %w", err)
+			}
+			_, err = pageTmpl.New("content").Funcs(funcMap).Parse(p.Template())
+			if err != nil {
+				return fmt.Errorf("failed to parse page template: %w", err)
+			}
 
-		data := map[string]interface{}{
-			"Title":        p.Name(),
-			"Pages":        allPages,
-			"CurrentPage":  filename,
-			"PageData":     p.PrepareData(history),
-			"FooterPrefix": footerPrefix,
-			"FooterText":   footerText,
-		}
+			data := map[string]interface{}{
+				"Title":        p.Name(),
+				"Pages":        allPages,
+				"CurrentPage":  filename,
+				"PageData":     p.PrepareData(history),
+				"FooterPrefix": footerPrefix,
+				"FooterText":   footerText,
+			}
 
-		if err := pageTmpl.Execute(f, data); err != nil {
-			return err
+			return pageTmpl.Execute(f, data)
+		}(); err != nil {
+			return fmt.Errorf("failed to generate %s: %w", filename, err)
 		}
 	}
 

pkg/cmd/inspect/inspect.go

@@ -4,6 +4,7 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
+	"log/slog"
 	"os"
 	"os/exec"
 	"strings"
@@ -53,7 +54,11 @@ func runInspect(opts *InspectOptions) error {
 	if err != nil {
 		return fmt.Errorf("failed to open zip: %w", err)
 	}
-	defer r.Close()
+	defer func() {
+		if err := r.Close(); err != nil {
+			slog.Warn("failed to close zip reader", "error", err)
+		}
+	}()
 
 	var output strings.Builder
 
@@ -76,7 +81,9 @@ func runInspect(opts *InspectOptions) error {
 
 			// Read file content
 			fileBytes, err := io.ReadAll(rc)
-			rc.Close()
+			if closeErr := rc.Close(); closeErr != nil {
+				output.WriteString(fmt.Sprintf("Warning: failed to close file: %v\n", closeErr))
+			}
 			if err != nil {
 				output.WriteString(fmt.Sprintf("Error reading file: %v\n\n", err))
 				continue

pkg/geocode/geocode.go

@@ -109,7 +109,11 @@ func (g *NominatimGeocoder) Geocode(address string) (*Coordinate, error) {
 	if err != nil {
 		return nil, fmt.Errorf("geocoding request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			slog.Debug("failed to close HTTP response body", "error", err)
+		}
+	}()
 
 	if resp.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("geocoding API returned status %d", resp.StatusCode)
@@ -221,7 +225,7 @@ func (g *NominatimGeocoder) SaveCache() error {
 	}
 
 	if err := os.Rename(tempPath, g.cachePath); err != nil {
-		os.Remove(tempPath) // Clean up temp file on error
+		_ = os.Remove(tempPath) // Best-effort cleanup
 		return fmt.Errorf("failed to rename cache file: %w", err)
 	}
 

pkg/tui/messages.go

@@ -7,13 +7,11 @@ import (
 // Color palette matching the HTML dashboard theme
 var (
 	// Primary colors
-	colorBlue    = lipgloss.Color("#58a6ff")
-	colorDarkBg  = lipgloss.Color("#24292e")
-	colorGray    = lipgloss.Color("#586069")
-	colorWhite   = lipgloss.Color("#ffffff")
-	colorGreen   = lipgloss.Color("#2ea44f")
-	colorOrange  = lipgloss.Color("#fb8500")
-	colorBorder  = lipgloss.Color("#30363d")
+	colorBlue   = lipgloss.Color("#58a6ff")
+	colorDarkBg = lipgloss.Color("#24292e")
+	colorGray   = lipgloss.Color("#586069")
+	colorWhite  = lipgloss.Color("#ffffff")
+	colorBorder = lipgloss.Color("#30363d")
 )
 
 // Header and navigation styles
@@ -27,11 +25,11 @@ var (
 	TabStyle = lipgloss.NewStyle().
 			Padding(0, 2)
 
-	ActiveTabStyle = TabStyle.Copy().
+	ActiveTabStyle = TabStyle.
 			Foreground(colorBlue).
 			Bold(true)
 
-	InactiveTabStyle = TabStyle.Copy().
+	InactiveTabStyle = TabStyle.
 				Foreground(colorWhite)
 )