refactor: More clean up

Author: jcs090218

Assets/JCSUnity/Scripts/Actions/2D/AI/JCS_2DInitLookByTypeAction.cs

@@ -134,7 +134,7 @@ protected override void Start()
             // Use player from "JCS_GameManager" as default
             if (mTargetTransform == null)
             {
-                JCS_Player player = JCS_GameManager.FirstInstance().Player;
+                JCS_Player player = JCS_GameManager.FirstInstance().player;
                 if (player != null)
                     SetFollowTarget(player.transform);
             }

Assets/JCSUnity/Scripts/Actions/2D/AI/JCS_2DInitLookByTypeAction.cs.meta

@@ -120,10 +120,6 @@ public class JCS_2DBullet : JCS_Bullet
         // timer in order to know when to do the effect.
         private float mLookTimer = 0;
 
-        [Tooltip("If this effect is active plz attach.")]
-        [SerializeField]
-        private JCS_2DInitLookByTypeAction mInitLookAction = null;
-
         /* Setter & Getter */
 
         public override float moveSpeed
@@ -152,9 +148,6 @@ protected override void Awake()
             if (mRandomAbsorbTime != 0)
                 mTimeToAbsorb += JCS_Random.Range(-mRandomAbsorbTime, mRandomAbsorbTime);
 
-            if (mInitLookAction == null)
-                mInitLookAction = this.GetComponent<JCS_2DInitLookByTypeAction>();
-
             if (mRandomTimeToLook != 0)
                 mTimeToLook += JCS_Random.Range(-mRandomTimeToLook, mRandomTimeToLook);
         }
@@ -252,9 +245,6 @@ private void DoInitLookByTypeEffect()
             if (!mInitLookByTypeAction)
                 return;
 
-            if (mInitLookAction == null)
-                return;
-
             mLookTimer += JCS_Time.ItTime(mTimeType);
 
             if (mLookTimer < mTimeToLook)
@@ -263,8 +253,6 @@ private void DoInitLookByTypeEffect()
             // count once
             ++mContinousLookCounter;
 
-            mInitLookAction.LockOnInit();
-
             // reset timer.
             mLookTimer = 0;
 

Assets/JCSUnity/Scripts/Interactive/2D/Camera/JCS_2DCamera.cs

@@ -44,7 +44,7 @@ protected virtual void Start()
 
         protected virtual void OnTriggerEnter(Collider other)
         {
-            JCS_Player player = JCS_GameManager.FirstInstance().Player;
+            JCS_Player player = JCS_GameManager.FirstInstance().player;
             if (player == null)
                 return;
 
@@ -58,7 +58,7 @@ protected virtual void OnTriggerEnter(Collider other)
 
         protected virtual void OnTriggerExit(Collider other)
         {
-            JCS_Player player = JCS_GameManager.FirstInstance().Player;
+            JCS_Player player = JCS_GameManager.FirstInstance().player;
             if (player == null)
                 return;
 

Assets/JCSUnity/Scripts/Interactive/2D/GameObjects/JCS_2DBullet.cs

@@ -65,7 +65,7 @@ protected virtual void Awake()
         protected virtual void Start()
         {
             // set Execute order lower than "JCS_GameManager"
-            JCS_GameManager.FirstInstance().Player = this;
+            JCS_GameManager.FirstInstance().player = this;
 
             // Player Manager will take care of all the player
             JCS_PlayerManager.FirstInstance().AddPlayerToManage(this);

Assets/JCSUnity/Scripts/Interactive/2D/JCS_2DPlatform.cs

@@ -6,6 +6,7 @@
  * $Notice: See LICENSE.txt for modification and distribution information 
  *                   Copyright (c) 2016 by Shen, Jen-Chieh $
  */
+using MyBox;
 using System.Collections.Generic;
 using UnityEngine;
 
@@ -18,8 +19,11 @@ public class JCS_2DGameManager : JCS_Manager<JCS_2DGameManager>
     {
         /* Variables */
 
-        // a list of item object will ignore their collision detection.
-        private List<JCS_2DPositionPlatform> mPlatformList = null;
+        [Separator("Check Variables (JCS_2DGameManager)")]
+
+        [Tooltip("A list of item object will ignore their collision detection.")]
+        [SerializeField]
+        private List<JCS_2DPositionPlatform> mPlatforms = null;
 
         /* Setter & Getter */
 
@@ -28,8 +32,6 @@ public class JCS_2DGameManager : JCS_Manager<JCS_2DGameManager>
         private void Awake()
         {
             RegisterInstance(this);
-
-            mPlatformList = new List<JCS_2DPositionPlatform>();
         }
 
         /// <summary>
@@ -38,7 +40,7 @@ private void Awake()
         /// <param name="pp"></param>
         public void AddPlatformList(JCS_2DPositionPlatform pp)
         {
-            mPlatformList.Add(pp);
+            mPlatforms.Add(pp);
         }
 
         /// <summary>
@@ -47,9 +49,9 @@ public void AddPlatformList(JCS_2DPositionPlatform pp)
         /// <param name="c"> collder to set to ignore trigger. </param>
         public void IgnoreAllPlatformTrigger(Collider c)
         {
-            for (int index = 0; index < mPlatformList.Count; ++index)
+            for (int index = 0; index < mPlatforms.Count; ++index)
             {
-                Physics.IgnoreCollision(mPlatformList[index].GetPlatformTrigger(), 
+                Physics.IgnoreCollision(mPlatforms[index].GetPlatformTrigger(),
                     c, true);
             }
         }
@@ -60,9 +62,9 @@ public void IgnoreAllPlatformTrigger(Collider c)
         /// <param name="c"> collider to set to ignore collider. </param>
         public void IgnoreAllPlatformCollider(Collider c)
         {
-            for (int index = 0; index < mPlatformList.Count; ++index)
+            for (int index = 0; index < mPlatforms.Count; ++index)
             {
-                Physics.IgnoreCollision(mPlatformList[index].GetPlatformCollider(),
+                Physics.IgnoreCollision(mPlatforms[index].GetPlatformCollider(),
                     c, true);
             }
         }

Assets/JCSUnity/Scripts/Interfaces/JCS_Player.cs

@@ -70,6 +70,7 @@ public JCS_3DWalkAction OverlapWithOthers(JCS_3DWalkAction self, Vector3 targetP
                 if (distance <= overlapDistance)
                     return wa;
             }
+
             return null;
         }
     }