style: Improve item droppable code

Author: jcs090218

Assets/JCSUnity/Scripts/Effects/Item/JCS_Item.cs

@@ -6,6 +6,7 @@
  * $Notice: See LICENSE.txt for modification and distribution information 
  *                   Copyright (c) 2016 by Shen, Jen-Chieh $
  */
+using System;
 using UnityEngine;
 using MyBox;
 
@@ -18,13 +19,13 @@ namespace JCSUnity
     [RequireComponent(typeof(Rigidbody))]
     public class JCS_Item : JCS_UnityObject
     {
-        public delegate void PickedFunction(Collider other);
-
         /* Variables */
 
-        public PickedFunction pickedCallback = DefaultPickCallback;
+        // Execution after the item is picked.
+        public Action<Collider> onPicked = null;
 
         protected bool mCanPick = true;
+
         protected BoxCollider mBoxCollider = null;
 
         [Separator("Check Variables (JCS_Item)")]
@@ -188,15 +189,6 @@ public void Pick(Collider other)
             }
         }
 
-        /// <summary>
-        /// Default pick up callback.
-        /// </summary>
-        /// <param name="other"></param>
-        public static void DefaultPickCallback(Collider other)
-        {
-            // do anything after the character pick this item up.
-        }
-
         /// <summary>
         /// Do pick up item action.
         /// </summary>
@@ -214,7 +206,7 @@ private void DoPick(Collider other)
                 sp.PlayOneShot(mPickSound);
 
             // call item effect.
-            pickedCallback.Invoke(other);
+            onPicked?.Invoke(other);
 
             /* Play Effect Sound */
             if (mPlayOneShotWhileNotPlayingForEffectSound)

Assets/JCSUnity/Scripts/Effects/Item/JCS_ItemDroppable.cs

@@ -6,6 +6,7 @@
  * $Notice: See LICENSE.txt for modification and distribution information 
  *                   Copyright (c) 2016 by Shen, Jen-Chieh $
  */
+using System;
 using UnityEngine;
 using MyBox;
 
@@ -19,14 +20,14 @@ public class JCS_ItemDroppable : MonoBehaviour
     {
         /* Variables */
 
-        [System.Serializable]
+        [Serializable]
         public struct ItemSet
         {
             [Tooltip("Possibilty droping this item, the higher the more possiblility.")]
             [Range(0.0f, 100.0f)]
             public float dropRate;
 
-            [Tooltip("Item to drop")]
+            [Tooltip("Item to drop.")]
             public JCS_Item item;
         };
 

Assets/_BossFight/Scripts/BF_GoldObject.cs

@@ -33,7 +33,7 @@ protected override void Awake()
         // set the picking collider
         PickCollider = BF_GameManager.instance.COLLECT_GOLD_OBJECT;
 
-        pickedCallback = AfterPicked;
+        onPicked = AfterPicked;
     }
 
     /// <summary>

Assets/_BossFight/Scripts/BF_PickItem.cs

@@ -39,7 +39,7 @@ protected override void Awake()
         // set the picking collider
         PickCollider = BF_GameManager.instance.COLLECT_GOLD_OBJECT;
 
-        pickedCallback = AfterPicked;
+        onPicked = AfterPicked;
 
         // try to get the optional variables.
         if (mEffectPickItem == null)

Assets/_RunningCrush/Scripts/RC_EffectItem.cs

@@ -32,7 +32,7 @@ protected override void Awake()
         // disable auto detect
         mEffectObject.AutoEffect = false;
 
-        pickedCallback = AfterPicked;
+        onPicked = AfterPicked;
     }
 
     private void AfterPicked(Collider other)

Assets/_RunningCrush/Scripts/RC_GoldObject.cs

@@ -27,7 +27,7 @@ protected override void Awake()
         // set to auto pick auto matically.
         mAutoPickColliderTouched = true;
 
-        pickedCallback = AfterPicked;
+        onPicked = AfterPicked;
     }
 
     private void AfterPicked(Collider other)

docs/ScriptReference/Effects/Item/JCS_Item.md

@@ -6,6 +6,7 @@ Base class for all the item subclasses.
 
 | Name                                      | Description                                                |
 |:------------------------------------------|:-----------------------------------------------------------|
+| onPicked                                  | Execution after the item is picked.                        |
 | mMustBeActivePlayer                       | Must be an active player in order to pick this item up.    |
 | mPickKey                                  | Key to pick this item up.                                  |
 | mPickByMouseDown                          | Pick up the item by mouse.                                 |