Skip to content

Commit da9e0da

Browse files
committed
feat: Use generic type instead
1 parent 84c8910 commit da9e0da

File tree

6 files changed

+26
-18
lines changed

6 files changed

+26
-18
lines changed

Assets/JCSUnity/Editor/JCSUnity_EditorWindow.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,8 @@ private static GameObject Create3DCurosr()
549549
/// </summary>
550550
private static GameObject CreateBasePanel()
551551
{
552-
var canvas = JCS_Util.FindObjectByType(typeof(JCS_Canvas)) as JCS_Canvas;
552+
var canvas = JCS_Util.FindObjectByType<JCS_Canvas>();
553+
553554
if (canvas == null)
554555
{
555556
Debug.Log("Can't find JCS_Canvas in hierarchy. Plz create canvas before creating new panel.");
@@ -577,7 +578,8 @@ private static GameObject CreateBasePanel()
577578
/// </summary>
578579
private static GameObject CreateDialoguePanel()
579580
{
580-
var canvas = JCS_Util.FindObjectByType(typeof(JCS_Canvas)) as JCS_Canvas;
581+
var canvas = JCS_Util.FindObjectByType<JCS_Canvas>();
582+
581583
if (canvas == null)
582584
{
583585
Debug.Log("Can't find JCS_Canvas in hierarchy. Plz create canvas before creating new panel.");
@@ -605,7 +607,7 @@ private static GameObject CreateDialoguePanel()
605607
/// </summary>
606608
private static void CreateSlidePanel()
607609
{
608-
var canvas = JCS_Util.FindObjectByType(typeof(JCS_Canvas)) as JCS_Canvas;
610+
var canvas = JCS_Util.FindObjectByType<JCS_Canvas>();
609611

610612
if (canvas == null)
611613
{
@@ -680,7 +682,7 @@ private static void CreateSlidePanel()
680682
/// </summary>
681683
private static GameObject CreateTweenPanel()
682684
{
683-
var canvas = JCS_Util.FindObjectByType(typeof(JCS_Canvas)) as JCS_Canvas;
685+
var canvas = JCS_Util.FindObjectByType<JCS_Canvas>();
684686

685687
if (canvas == null)
686688
{
@@ -810,7 +812,7 @@ private static GameObject CreateHierarchyObjectUnderCanvas(string settingPath)
810812
{
811813
// since this will be in the editing time.
812814
// so we don't worry to much about the performance.
813-
var canvas = JCS_Util.FindObjectByType(typeof(JCS_Canvas)) as JCS_Canvas;
815+
var canvas = JCS_Util.FindObjectByType<JCS_Canvas>();
814816

815817
return CreateHierarchyObjectUnderCanvas(settingPath, canvas);
816818
}

Assets/JCSUnity/Scripts/Interactive/2D/Camera/JCS_2DMultiTrackCamera.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ protected void Awake()
8585
mAudioListener = GetComponent<AudioListener>();
8686

8787
// find the camera in the scene first
88-
mCamera = JCS_Util.FindObjectByType(typeof(JCS_2DCamera)) as JCS_2DCamera;
88+
mCamera = JCS_Util.FindObjectByType<JCS_2DCamera>();
8989

9090
if (mCamera == null)
9191
return;

Assets/JCSUnity/Scripts/Managers/JCS_PlayerManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ public JCS_Player FindPlayerByDirectionUsingList(JCS_2D4Direction direction, Lis
382382
public void AddAllPlayerToMultiTrack()
383383
{
384384
// find the object in the scene.
385-
var mtc = JCS_Util.FindObjectByType(typeof(JCS_2DMultiTrackCamera)) as JCS_2DMultiTrackCamera;
385+
var mtc = JCS_Util.FindObjectByType<JCS_2DMultiTrackCamera>();
386386

387387
foreach (JCS_Player p in mPlayers)
388388
{
@@ -396,7 +396,7 @@ public void AddAllPlayerToMultiTrack()
396396
public void RemoveAllPlayerFromMultiTrack()
397397
{
398398
// find the object in the scene.
399-
var mtc = JCS_Util.FindObjectByType(typeof(JCS_2DMultiTrackCamera)) as JCS_2DMultiTrackCamera;
399+
var mtc = JCS_Util.FindObjectByType<JCS_2DMultiTrackCamera>();
400400

401401
foreach (JCS_Player p in mPlayers)
402402
{

Assets/JCSUnity/Scripts/UI/Button/Scene/JCS_SlideScreenButton.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ protected override void Awake()
8484
mSoundPlayer = GetComponent<JCS_SoundPlayer>();
8585

8686
// try to get it from the scene by type.
87-
mSlideCameras = JCS_Util.FindObjectsByType(typeof(JCS_2DSlideScreenCamera)) as JCS_2DSlideScreenCamera[];
87+
mSlideCameras = JCS_Util.FindObjectsByType<JCS_2DSlideScreenCamera>();
8888
}
8989

9090
#if JCS_USE_GAMEPAD

Assets/JCSUnity/Scripts/Util/JCS_Util.cs

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -794,13 +794,15 @@ public static string RemoveCloneString(string name)
794794
/// <summary>
795795
/// Retrieves the first active loaded object of Type type.
796796
/// </summary>
797-
public static Object FindObjectByType(System.Type type)
797+
public static T FindObjectByType<T>()
798+
where T : Object
798799
{
799-
return Object.FindFirstObjectByType(type);
800+
return Object.FindFirstObjectByType<T>();
800801
}
801-
public static Object FindObjectByType(System.Type type, Scene scene)
802+
public static T FindObjectByType<T>(Scene scene)
803+
where T : Object
802804
{
803-
Object[] objects = FindObjectsByType(type, scene);
805+
T[] objects = FindObjectsByType<T>(scene);
804806

805807
if (objects.Length == 0)
806808
return null;
@@ -811,13 +813,17 @@ public static Object FindObjectByType(System.Type type, Scene scene)
811813
/// <summary>
812814
/// Retrieves a list of all loaded objects of Type type.
813815
/// </summary>
814-
public static Object[] FindObjectsByType(System.Type type)
816+
public static T[] FindObjectsByType<T>()
817+
where T : Object
815818
{
816-
return Object.FindObjectsByType(type, FindObjectsSortMode.None);
819+
return Object.FindObjectsByType<T>(
820+
FindObjectsInactive.Include,
821+
FindObjectsSortMode.None);
817822
}
818-
public static Object[] FindObjectsByType(System.Type type, Scene scene)
823+
public static T[] FindObjectsByType<T>(Scene scene)
824+
where T : Object
819825
{
820-
Object[] objects = FindObjectsByType(type);
826+
T[] objects = FindObjectsByType<T>();
821827

822828
return objects.Where((obj) =>
823829
{

Assets/_RunningCrush/Scripts/RC_WebcamHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ private void Start()
4242

4343
// try to get the object
4444
if (mWebcam == null)
45-
mWebcam = JCS_Util.FindObjectByType(typeof(JCS_Webcam)) as JCS_Webcam;
45+
mWebcam = JCS_Util.FindObjectByType<JCS_Webcam>();
4646
}
4747

4848
private void Update()

0 commit comments

Comments
 (0)