refactor(Manager): Improve register event on after init

Author: jcs090218

Assets/JCSUnity/Scripts/Managers/JCS_AppManager.cs

@@ -158,7 +158,7 @@ private void Awake()
 
         private void Start()
         {
-            JCS_GameManager.instance.onSystemAfterInitialize += RefreshSimulateLanguage;
+            JCS_GameManager.instance.RegisterOnSystemAfterInit(RefreshSimulateLanguage);
         }
 
         private void OnValidate()

Assets/JCSUnity/Scripts/Managers/JCS_GameManager.cs

@@ -20,10 +20,10 @@ public class JCS_GameManager : JCS_Manager<JCS_GameManager>
         /* Variables */
 
         // Callback after the game is done initialize. (system used)
-        public Action onSystemAfterInitialize = null;
+        private Action mOnSystemAfterInitialize = null;
 
         // Callback after the game is done initialize.
-        public Action onAfterInitialize = null;
+        private Action mOnAfterInitialize = null;
 
         [Separator("Check Variable (JCS_GameManager)")]
 
@@ -69,6 +69,39 @@ private void Awake()
             Invoke("OnFirstFrame", 0.0f);
         }
 
+        /// <summary>
+        /// Register event run on the first frame of the game.
+        /// </summary>
+        public void RegisterOnAfterInit(Action action)
+        {
+            // Already initialize, just execute it.
+            if (mDoneInitialize)
+            {
+                action?.Invoke();
+                return;
+            }
+
+            mOnAfterInitialize += action;
+        }
+
+        /// <summary>
+        /// Register event run on the first frame of the game.
+        /// </summary>
+        public void RegisterOnSystemAfterInit(Action action)
+        {
+            // Already initialize, just execute it.
+            if (mDoneInitialize)
+            {
+                action?.Invoke();
+                return;
+            }
+
+            mOnSystemAfterInitialize += action;
+        }
+
+        /// <summary>
+        /// Run only once on the first frame.
+        /// </summary>
         private void OnFirstFrame()
         {
             SetDoneInitializeFlag();
@@ -99,12 +132,9 @@ private void SetDoneInitializeFlag()
 
             this.mDoneInitialize = true;
 
-            if (onSystemAfterInitialize != null)
-                onSystemAfterInitialize.Invoke();
+            mOnSystemAfterInitialize?.Invoke();
 
-            if (onAfterInitialize != null)
-                onAfterInitialize.Invoke();
+            mOnAfterInitialize?.Invoke();
         }
     }
 }
-

Assets/JCSUnity/Scripts/Settings/JCS_AppSettings.cs

@@ -73,7 +73,7 @@ private void Start()
         {
             // If already starts we don't need to enable the flag.
             if (!APPLICATION_STARTS)
-                JCS_GameManager.instance.onAfterInitialize += DoApplicationStart;
+                JCS_GameManager.instance.RegisterOnAfterInit(DoApplicationStart);
         }
 
         /// <summary>

Assets/JCSUnity/Scripts/UI/Slider/JCS_SoundSlider.cs

@@ -54,7 +54,7 @@ private void Start()
             if (mMixer == null)
                 mMixer = JCS_SoundSettings.instance.MIXER;
 
-            AddListener();
+            JCS_GameManager.instance.RegisterOnAfterInit(AddListener);
         }
 
         private void OnValidate()

Assets/JCSUnity/Scripts/UI/Undo Redo/JCS_UndoRedoComponent.cs

@@ -38,7 +38,7 @@ public class JCS_UndoRedoComponent : JCS_GUIObject
         [SerializeField]
         private JCS_KeyWith mRedoKey = new JCS_KeyWith
         {
-            comb = JCS_KeyCombination.ALT, 
+            comb = JCS_KeyCombination.ALT,
             key = KeyCode.S,
         };
 #endif
@@ -170,9 +170,9 @@ private void Start()
             // to be as late as possible. Cuz any script change 
             // the UI value after this will not be record...
             {
-                JCS_GameManager gm = JCS_GameManager.instance;
+                var gm = JCS_GameManager.instance;
 
-                gm.onAfterInitialize += RecordPrevData;
+                gm.RegisterOnAfterInit(RecordPrevData);
             }
         }
 
@@ -897,7 +897,9 @@ private void DoFocusAfterUndoRedoAction()
                 case JCS_GUIType.TOGGLE:
                     {
                         if (mToggle != null)
+                        {
                             mToggle.Select();
+                        }
                         else if (mSwitch != null)
                         {
                             // empty..