If you're using Kontrol S MK2/A/M and OSARA, ReaKontrol will now report FX parameter values itself.

OSARA's control surface feedback is still a bit verbose in some cases.
Also, ReaKontrol knows which parameter is being adjusted using Kontrol, so it can avoid reporting changes to other values.
Contrary to previous guidance, you should now disable OSARA's "Report changes made via control surfaces" setting.

Author: jcsteh

readme.md

@@ -50,7 +50,7 @@ Earlier Kontrol keyboards do not officially support non-NKS FX parameters.
 However, ReaKontrol provides support for this.
 To access them, press the Mixer button on S MK2, or Track button on A/M series keyboards, then press the 4-d encoder.
 You then use the knobs to adjust parameters.
-If you're using a screen reader, you will need to enable OSARA's "Report changes made via control surfaces" setting to have parameter changes reported.
+If you're using a screen reader, you should disable OSARA's "Report changes made via control surfaces" setting, as ReaKontrol will report parameter changes itself.
 Note also that touching a knob will not provide any feedback.
 Instead, you can quickly turn a knob first to report its parameter and value.
 Subsequent turns will adjust the value.

src/niMidi.cpp

@@ -581,6 +581,7 @@ class NiMidiSurface: public BaseSurface {
 	FxMap _fxMap;
 	int _suppressFxParam = -1;
 	DWORD _suppressFxParamStartTime = 0;
+	string _lastFxParamValueOsara;
 
 	void _onTrackBankChange() {
 		if (this->_isUsingMixerForFx()) {
@@ -905,6 +906,11 @@ class NiMidiSurface: public BaseSurface {
 			this->_selectedFx, param, value, valText, sizeof(valText));
 		command = isMixer ? CMD_TRACK_VOLUME_TEXT : CMD_PARAM_VALUE_TEXT;
 		this->_sendSysex(command, 0, numInBank, valText);
+		if (osara_outputMessage && isMixer && param == this->_lastChangedFxParam &&
+				this->_lastFxParamValueOsara != valText) {
+			osara_outputMessage(valText);
+			this->_lastFxParamValueOsara = valText;
+		}
 	}
 
 	void _navigateFxBanks(bool next) {