fix warnings (#239)

* Create overview.md

* compilation passed.

* feat: fix warnings in common/

* fix: agent-watchdog warnings.

* fix: dtcagent warnings.

* fix: dtcd warnings part 1

* fix: compilation warnings in hwcserver and connector/1

* fix: warnings in connector

* fix: warning in dtcd

* fix: warnings in utils

Author: norton-yang

.gitignore

@@ -5,4 +5,5 @@
 settings.json
 *.o
 .dep*
-build/
+build/
+.joycode

CMakeLists.txt

@@ -1,6 +1,42 @@
-CMAKE_MINIMUM_REQUIRED (VERSION 2.8)
+CMAKE_MINIMUM_REQUIRED (VERSION 3.10)
+
+# Set modern CMake policies
+if(POLICY CMP0074)
+  cmake_policy(SET CMP0074 NEW)  # Find_package uses <PackageName>_ROOT variables
+endif()
+if(POLICY CMP0077)
+  cmake_policy(SET CMP0077 NEW)  # option() honors normal variables
+endif()
+
 PROJECT(dtc)
 
+# Set default build type if not specified
+if(NOT CMAKE_BUILD_TYPE)
+  set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "Build type" FORCE)
+endif()
+
+# Enable modern compiler features while maintaining GCC 4.9 compatibility
+set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_CXX_EXTENSIONS OFF)
+
+# Compiler-specific flags for modern GCC support
+if(CMAKE_COMPILER_IS_GNUCXX)
+  # Add compiler version checks for better compatibility
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "6.0")
+    # Modern GCC flags
+    add_compile_options(-Wno-misleading-indentation)
+    add_compile_options(-Wno-address-of-packed-member)
+  endif()
+  
+  # Common flags for all GCC versions
+  add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:-fpermissive>")
+  add_compile_options(-Wno-builtin-macro-redefined)
+  
+  # Use old ABI for compatibility with bundled libraries
+  add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0)
+endif()
+
 #Use optional command `cmake -DCMAKE_TEST_OPTION=ON ..` to build test demo.
 option(CMAKE_TEST_OPTION "option for test_demo" OFF)
 

conf/server.yaml

@@ -0,0 +1,6 @@
+rules:
+  - !AUTHORITY
+    users:
+      - sharding@%:sharding
+    provider:
+      type: ALL_PERMITTED

src/agent-watchdog/CMakeLists.txt

@@ -2,9 +2,9 @@ INCLUDE_DIRECTORIES(
     ${PROJECT_SOURCE_DIR}/src/daemons
     ${PROJECT_SOURCE_DIR}/src/libs/common
     ${PROJECT_SOURCE_DIR}/src/libs/stat
-    ${PROJECT_SOURCE_DIR}/src/core
     ${PROJECT_SOURCE_DIR}/src/libs/log4cplus/include
     ${PROJECT_SOURCE_DIR}/src/libs/yaml-cpp/include
+    ${PROJECT_SOURCE_DIR}/src/core
     ${PROJECT_SOURCE_DIR}/src/libs/mxml/include)
 
 LINK_DIRECTORIES(
@@ -16,8 +16,8 @@ LINK_DIRECTORIES(
 
 include(../utils.cmake)
 
-FILE(GLOB_RECURSE SRC_LIST1 ./*.cc ./*.c)
-
+FILE(GLOB_RECURSE CXX_SRC_LIST ./*.cc)
+FILE(GLOB_RECURSE C_SRC_LIST ./*.c)
 
 LINK_LIBRARIES(liblog4cplus.a) 
 LINK_LIBRARIES(libcommon.a)
@@ -26,10 +26,13 @@ LINK_LIBRARIES(libstat.a)
 LINK_LIBRARIES(pthread)
 LINK_LIBRARIES(dl)
 
-ADD_DEFINITIONS("-g -fPIC -fpermissive -std=gnu++11")
-ADD_DEFINITIONS(-Wno-builtin-macro-redefined)
+# Set properties for C++ files
+set_source_files_properties(${CXX_SRC_LIST} PROPERTIES COMPILE_FLAGS "-g -fPIC -fpermissive -std=gnu++11 -D_GLIBCXX_USE_CXX11_ABI=0 -Wno-builtin-macro-redefined")
+
+# Set properties for C files  
+set_source_files_properties(${C_SRC_LIST} PROPERTIES COMPILE_FLAGS "-g -fPIC -Wno-builtin-macro-redefined")
 
-ADD_EXECUTABLE(agent-watchdog ${SRC_LIST1})
+ADD_EXECUTABLE(agent-watchdog ${CXX_SRC_LIST} ${C_SRC_LIST})
 
 TARGET_LINK_LIBRARIES(agent-watchdog libstat.a libcommon.a libyaml-cpp.a liblog4cplus.a mxml)
 redefine_file_macro(agent-watchdog)

src/agent-watchdog/daemons.cc

@@ -88,7 +88,8 @@ void close_sharding()
 	p[0] = NULL;
 	execv("../sharding/bin/stop.sh", p);
 
-	system("../sharding/bin/stop.sh");
+	int result = system("../sharding/bin/stop.sh");
+	(void)result; // Silence unused result warning
 }
 
 void WatchDog::run_loop()

src/agent-watchdog/main.cc

@@ -26,7 +26,7 @@ std::map<std::string, std::string> map_dtc_conf; //key:value --> dtc addr:conf f
 #define DA_STRING(x)			DA_STRING_HELPER(x)
 
 #define DA_VERSION_STR \
-	DA_STRING(DA_VERSION_MAJOR)"."DA_STRING(DA_VERSION_MINOR)"."\
+	DA_STRING(DA_VERSION_MAJOR) "." DA_STRING(DA_VERSION_MINOR) "." \
 	DA_STRING(DA_VERSION_BUILD)
 
 static int show_help;
@@ -368,7 +368,7 @@ int get_all_dtc_confs()
 		int content_len = 0;
 		log4cplus_debug("addr:%s", addr.c_str());
 		std::string str = send_select_dtcyaml((addr.substr(0, addr.find(':'))).c_str(), atoi((addr.substr(addr.find(':')+1)).c_str()));
-		content = str.c_str();
+		content = const_cast<char*>(str.c_str());
 		content_len = str.length();
 		log4cplus_debug("content:%s", content);
 

src/agent-watchdog/sharding_entry.cc

@@ -39,8 +39,8 @@ void ShardingEntry::exec()
 	{
 		set_proc_title("agent_sharding");
 		argv[0] = (char *)"../sharding/bin/start.sh";
-		argv[1] = "3307";
-		argv[2] = "../conf";
+		argv[1] = const_cast<char*>("3307");
+		argv[2] = const_cast<char*>("../conf");
 		argv[3] = NULL;
 		execv(argv[0], argv);
 	}

src/agent/common/da_string.c

@@ -130,8 +130,8 @@ int string_compare_nonsentive(const struct string *s1, const struct string *s2)
 		return s1->len > s2->len ? 1 : -1;
 	}
 
-	string_copy(&tmp1, s1, s1->len);
-	string_copy(&tmp2, s2, s2->len);
+	string_copy(&tmp1, s1->data, s1->len);
+	string_copy(&tmp2, s2->data, s2->len);
 	string_upper(&tmp1);
 	string_upper(&tmp2);
 	return da_strncmp(&tmp1.data, &tmp2.data, &tmp1.len);

src/agent/da_conn.c

@@ -14,6 +14,7 @@
 * limitations under the License.
 */
 #include <inttypes.h>
+#include <sys/uio.h>
 #include "da_mem_pool.h"
 #include "da_conn.h"
 #include "da_listener.h"

src/agent/da_listener.c

@@ -22,6 +22,7 @@
 #include "da_core.h"
 #include "da_event.h"
 #include "da_stats.h"
+#include "my/my_net_send.h"
 #include "da_msg.h"
 
 void listener_ref(struct conn *l, void *owner)