Skip to content

Commit c60344e

Browse files
committed
Refactor GetApplicationEnvironments call to use local variables for clarity and add logging for environment variables
1 parent f6343bf commit c60344e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/mutation/mutation_deploy.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func injectionDeploy(request *admissionv1.AdmissionRequest) (*admissionv1.Admiss
8686
labels := deploy.GetLabels()
8787
serviceSpace, application := labels[config.ServiceSpaceLabel], labels[config.ApplicationLabel]
8888
if len(serviceSpace) > 0 && len(application) > 0 {
89-
envs, err := resource.GetApplicationEnvironments(labels[config.ServiceSpaceLabel], labels[config.ApplicationLabel])
89+
envs, err := resource.GetApplicationEnvironments(serviceSpace, application)
9090
if err != nil {
9191
errMsg := fmt.Sprintf("[mutation] /injection-deploy: failed to get application environments: %v", err)
9292
log.Error(errMsg)
@@ -101,6 +101,8 @@ func injectionDeploy(request *admissionv1.AdmissionRequest) (*admissionv1.Admiss
101101
for k, v := range envs {
102102
deploy.Spec.Template.Spec.Containers[0].Env = append(deploy.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{Name: k, Value: v})
103103
}
104+
log.Infof("[mutation] /injection-deploy: add envs to deployment %s/%s, envs: %v, deploy's envs: %v",
105+
deploy.Name, deploy.Namespace, envs, deploy.Spec.Template.Spec.Containers[0].Env)
104106
} else {
105107
log.Warnf("[mutation] /injection-deploy: the deployment %s/%s does not have the %s or %s label",
106108
deploy.Name, deploy.Namespace, config.ServiceSpaceLabel, config.ApplicationLabel)

0 commit comments

Comments
 (0)