Merge pull request #1249 from ZeroTo0ne/fix-component-tabs

Chen-jj · web-flow · commit 6348fa5cfffe · 2021-04-26T17:20:14.000+08:00
fix(tabs): change tab key to fix possible problems when using tab title as a key
diff --git a/packages/taro-ui/src/components/tabs/index.tsx b/packages/taro-ui/src/components/tabs/index.tsx
@@ -186,7 +186,7 @@ export default class AtTabs extends React.Component<AtTabsProps, AtTabsState> {
         <View
           className={itemCls}
           id={`tab${this._tabId}${idx}`}
-          key={item.title}
+          key={`at-tabs-item-${idx}`}
           onClick={this.handleClick.bind(this, idx)}
         >
           {item.title}

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export default class AtTabs extends React.Component<AtTabsProps, AtTabsState> {`
`186`	`186`	`<View`
`187`	`187`	`className={itemCls}`
`188`	`188`	id={`tab${this._tabId}${idx}`}
`189`		`- key={item.title}`
	`189`	+ key={`at-tabs-item-${idx}`}
`190`	`190`	`onClick={this.handleClick.bind(this, idx)}`
`191`	`191`	`>`
`192`	`192`	`{item.title}`