feat: optimize kv cache load/offload. #306
Open
+1,820
−814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kang-Meng
requested review from
RobbieLeung,
liutongxuan,
walsonyang and
yq33victor
Kang-Meng
force-pushed
the
feat_async_copy
branch
3 times, most recently
from
17797ce to
034f86e
Compare
RobbieLeung
reviewed
Nov 5, 2025
| return torch::Tensor(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Add a TODO tag, MTP need more support.
Kang-Meng
force-pushed
the
feat_async_copy
branch
2 times, most recently
from
7cd5bd4 to
d4446aa
Compare
liutongxuan
reviewed
Nov 6, 2025
| public: | ||
| ~ServerStreamHandler() { | ||
| if (!promise_set_.exchange(true)) { | ||
| try { |
There was a problem hiding this comment.
why use try catch here?
liutongxuan
reviewed
Nov 6, 2025
| std::unique_ptr<std::thread> polling_thread_; | ||
|
|
||
| std::unique_ptr<ThreadPool> threadpool_; | ||
| ThreadPool copy_threadpool_{5}; |
Kang-Meng
force-pushed
the
feat_async_copy
branch
from
349a778 to
844f089
Compare
Kang-Meng
force-pushed
the
feat_async_copy
branch
from
844f089 to
64f071c
Compare
Kang-Meng
force-pushed
the
feat_async_copy
branch
from
64f071c to
eee6a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.