Translator on current builder

We set our own translator in the translators defined by other extensions, but
also for the current builder.

It may happen that there is an extension that defines two translators for
`dirhml` and `json`, and we are going to override them --the problem comes when
`sphinx-build` is called with `-b custombuilder` since we weren't overriding it
in that case.

This commit override the ones defined by the user, but also the default one.

Author: humitos

hoverxref/extension.py

@@ -147,31 +147,31 @@ def setup_translators(app):
     and our own ``HoverXRefHTMLTranslatorMixin`` that includes the logic to
     ``_hoverxref`` attributes.
     """
-    if not app.registry.translators.items():
+    for name, klass in app.registry.translators.items():
+        if app.builder.format != 'html':
+            # Skip translators that are not HTML
+            continue
+
         translator = types.new_class(
             'HoverXRefHTMLTranslator',
             (
                 HoverXRefHTMLTranslatorMixin,
-                app.builder.default_translator_class,
+                klass,
             ),
             {},
         )
-        app.set_translator(app.builder.name, translator, override=True)
-    else:
-        for name, klass in app.registry.translators.items():
-            if app.builder.format != 'html':
-                # Skip translators that are not HTML
-                continue
-
-            translator = types.new_class(
-                'HoverXRefHTMLTranslator',
-                (
-                    HoverXRefHTMLTranslatorMixin,
-                    klass,
-                ),
-                {},
-            )
-            app.set_translator(name, translator, override=True)
+        app.set_translator(name, translator, override=True)
+
+    translator = types.new_class(
+        'HoverXRefHTMLTranslator',
+        (
+            HoverXRefHTMLTranslatorMixin,
+            app.builder.default_translator_class,
+        ),
+        {},
+    )
+    app.set_translator(app.builder.name, translator, override=True)
+
 
 
 def is_hoverxref_configured(app, config):