Minor assorted cleanup

Author: jdahlstrom

core/src/geom.rs

@@ -382,8 +382,6 @@ impl<B> Plane3<B> {
     /// ```
     pub fn from_point_and_normal(pt: Point3<B>, n: Normal3) -> Self {
         let n = n.normalize();
-        // For example, if pt = (0, 1, 0) and n = (0, 1, 0), d has to be 1
-        // to satisfy the plane equation n_x + n_y + n_z = d
         let d = pt.to_vec().dot(&n.to());
         Plane::new(n.x(), n.y(), n.z(), d)
     }

core/src/math/point.rs

@@ -586,7 +586,7 @@ mod tests {
     mod u32 {
         use super::*;
 
-        const pt2: fn(u32, u32) -> Point2u = super::super::pt2;
+        const pt2: fn(u32, u32) -> Point2u = super::pt2;
 
         #[test]
         fn vector_addition() {

core/src/math/space.rs

@@ -2,11 +2,13 @@
 //!
 //! TODO
 
-use core::fmt::{Debug, Formatter};
-use core::iter::zip;
-use core::marker::PhantomData;
+use core::{
+    fmt::{Debug, Formatter},
+    iter::zip,
+    marker::PhantomData,
+};
 
-use crate::math::vary::{Iter, Vary, ZDiv};
+use super::vary::{Iter, Vary, ZDiv};
 
 /// Trait for types representing elements of an affine space.
 ///

core/src/math/spline.rs

@@ -88,7 +88,8 @@ where
     /// stable than [`Self::eval`].
     pub fn fast_eval(&self, t: f32) -> T {
         let [p0, .., p3] = &self.0;
-        step(t, p0, p3, |t| {
+
+        step(t, p0, p3, |_t| {
             // Add a linear combination of the three coefficients
             // to `p0` to get the result
             let [co3, co2, co1] = self.coefficients();

core/src/math/vec.rs

@@ -215,8 +215,7 @@ impl<Sp, const N: usize> Vector<[f32; N], Sp> {
         array::from_fn(|i| self[i].clamp(min[i], max[i])).into()
     }
 
-    /// Returns `true` if every component of `self` is finite,
-    /// `false` otherwise.
+    /// Returns `true` if every component of `self` is finite, `false` otherwise.
     ///
     /// See [`f32::is_finite()`].
     pub fn is_finite(&self) -> bool {
@@ -231,14 +230,16 @@ where
 {
     /// Returns the length of `self`, squared.
     ///
-    /// This avoids taking the square root in cases it's not needed,
+    /// This avoids taking the square root in cases where it's not needed,
     /// and works with scalars for which a square root is not defined.
     #[inline]
     pub fn len_sqr(&self) -> Sc {
         self.dot(self)
     }
 
     /// Returns the dot product of `self` and `other`.
+    ///
+    /// TODO docs
     #[inline]
     pub fn dot(&self, other: &Self) -> Sc {
         zip(&self.0, &other.0)

geom/src/io.rs

@@ -134,7 +134,7 @@ where
 /// Parses an OBJ format mesh from an iterator.
 ///
 /// # Errors
-/// Returns [`self::Error`] if OBJ parsing fails.
+/// Returns [`self::Error`][Error] if OBJ parsing fails.
 pub fn parse_obj<A>(src: impl IntoIterator<Item = u8>) -> Result<Builder<A>>
 where
     Builder<A>: TryFrom<Obj, Error = Error>,