Improve trait bounds

Author: jdh8

src/lib.rs

@@ -81,7 +81,7 @@ const LOG2_SIGNIFICAND: [f64; 16] = [
 /// [ops]: https://docs.rs/num-traits/latest/num_traits/trait.NumOps.html
 pub trait Minifloat: Copy + PartialEq + PartialOrd + Neg<Output = Self> {
     /// Storage type
-    type Bits: PrimInt + Unsigned;
+    type Bits: PrimInt + Unsigned + 'static;
 
     /// Whether the type is signed
     const S: bool = true;

tests/all.rs

@@ -1,6 +1,7 @@
 use core::fmt::Debug;
 use minifloat::example::*;
 use minifloat::{minifloat, Minifloat, NanStyle};
+use num_traits::AsPrimitive;
 
 minifloat!(struct F8E2M5(u8): 2, 5);
 minifloat!(struct F8E2M5FN(u8): 2, 5, FN);
@@ -9,6 +10,14 @@ minifloat!(struct F8E2M5FNUZ(u8): 2, 5, FNUZ);
 minifloat!(struct F8E3M4FNUZ(u8): 3, 4, FNUZ);
 minifloat!(struct F8E5M2FN(u8): 5, 2, FN);
 
+const fn bit_mask(width: u32) -> u64 {
+    if width == 0 {
+        0
+    } else {
+        u64::MAX >> (64 - width)
+    }
+}
+
 /// Test floating-point identity like Object.is in JavaScript
 ///
 /// This is necessary because NaN != NaN in C++.  We also want to differentiate
@@ -32,11 +41,17 @@ fn same_mini<T: Minifloat>(x: T, y: T) -> bool {
     x.to_bits() == y.to_bits() || x.is_nan() && y.is_nan()
 }
 
-fn for_all<T: Minifloat<Bits = u8>>(f: impl Fn(T) -> bool) -> bool {
-    (0..=u8::MAX).map(T::from_bits).all(f)
+fn for_all<T: Minifloat>(f: impl Fn(T) -> bool) -> bool
+where
+    u64: AsPrimitive<T::Bits>,
+{
+    (0..=bit_mask(T::BITWIDTH)).all(|bits| f(T::from_bits(bits.as_())))
 }
 
-fn check_equality<T: Minifloat<Bits = u8> + Debug>() -> bool {
+fn check_equality<T: Minifloat + Debug>() -> bool
+where
+    u64: AsPrimitive<T::Bits>,
+{
     let fixed_point = if T::M == 0 { 2.0 } else { 3.0 };
     assert!(same_f32(T::from_f32(fixed_point).to_f32(), fixed_point));