Change call syntax and drop v0.3 support

Author: jdlangs

README.md

@@ -139,22 +139,23 @@ example:
 ROS services are fully supported, including automatic request and response type
 generation. For the `@rosimport` call, use the plain service type name. After
 `rostypegen()`, the generated `.srv` submodule will contain 3 types: the plain
-type, a request type, and a response type. For example `GetPlan`,
-`GetPlanRequest`, and `GetPlanResponse`. To provide the service to other nodes,
-you would create a `Service{GetPlan}` object. To call it, a
-`ServiceProxy{GetPlan}` object. The syntax exactly matches rospy to construct
-and use these objects. The only exception is in Julia v0.3, where the `call`
-method is not overloaded for objects. In that case, you must call the
-`ServiceProxy` via `call(myproxy, myreq)` instead of the rospy method of
-`myproxy(myreq)` which works in later versions of Julia.
+type, a request type, and a response type. For example `@rosimport
+nav_msgs.srv.GetPlan` will create `GetPlan`, `GetPlanRequest`, and
+`GetPlanResponse`. To provide the service to other nodes, you would create a
+`Service{GetPlan}` object. To call it, a `ServiceProxy{GetPlan}` object. The
+syntax exactly matches rospy to construct and use these objects. For example,
+if `myproxy` is a `ServiceProxy` object, it can be called with
+`myproxy(my_request)`.
 
 ### Parameter Server
 
 `get_param`, `set_param`, `has_param`, and `delete_param` are all implemented
 in the `RobotOS` module with the same syntax as in rospy.
 
 ### Message Constants
-Message constants may be accessed using `getindex` syntax. For example for [visualization_msgs/Marker.msg](http://docs.ros.org/api/visualization_msgs/html/msg/Marker.html) we have:
+Message constants may be accessed using `getindex` syntax. For example for
+[visualization_msgs/Marker.msg](http://docs.ros.org/api/visualization_msgs/html/msg/Marker.html)
+we have:
 
     import visualization_msgs.msg: Marker
     Marker[:SPHERE] == getindex(Marker, :SPHERE) == 2   # true

REQUIRE

@@ -1,3 +1,3 @@
-julia 0.3
+julia 0.4
 PyCall
 Compat

src/gentypes.jl

@@ -1,5 +1,4 @@
 #Generate Julia composite types for ROS messages
-using Compat
 
 export @rosimport, rostypegen, rostypereset, gentypes, cleartypes
 
@@ -38,7 +37,7 @@ const _rospy_imports = Dict{ASCIIString,ROSPackage}()
 const _rospy_objects = Dict{ASCIIString,PyObject}()
 const _rospy_modules = Dict{ASCIIString,PyObject}()
 
-const _ros_builtin_types = @compat Dict{ASCIIString, Symbol}(
+const _ros_builtin_types = Dict{ASCIIString, Symbol}(
     "bool"    => :Bool,
     "int8"    => :Int8,
     "int16"   => :Int16,

src/services.jl

@@ -1,11 +1,7 @@
 #API for calling/creating services. Syntax is practically identical to rospy.
 export Service, ServiceProxy, wait_for_service
 
-if VERSION < v"0.4-"
-    export call
-else
-    import Base.call
-end
+using Compat
 
 type ServiceProxy{SrvType <: ServiceDefinition}
     o::PyObject
@@ -24,8 +20,7 @@ function ServiceProxy{SrvType<:ServiceDefinition}(
     ServiceProxy{SrvType}(ascii(name); kwargs...)
 end
 
-function call{SrvType <: ServiceDefinition}(
-    srv::ServiceProxy{SrvType},
+@compat function (srv::ServiceProxy{SrvType}){SrvType <: ServiceDefinition}(
     req::SrvT
 )
     if ! isa(req, _srv_reqtype(SrvType))

test/services.jl

@@ -31,7 +31,7 @@ const srvlisten = Service("getplan", GetPlan, srv_cb)
 println("Waiting for 'callme' service...")
 wait_for_service("callme")
 println("Calling service now")
-call(srvcall, EmptyRequest())
+srvcall(EmptyRequest())
 
 #Wait for call from echo
 println("Waiting for service call from echo..")
@@ -52,4 +52,4 @@ end
 
 #Test error handling
 @test_throws ErrorException wait_for_service("fake_srv", timeout=1.0)
-@test_throws ArgumentError call(srvcall, EmptyResponse())
+@test_throws ArgumentError srvcall(EmptyResponse())