fix(RecipeFakerService): correctly calculate left_digits for numeric and currency fields based on precision - scale

- Updated buildNumericRecipeValueWithPrecisionAndScale and buildCurrencyRecipeValueWithPrecisionAndScale to use left_digits = precision - effectiveScale, ensuring accurate representation of digits before the decimal point.
- Adjusted the corresponding test to expect left_digits=16 for a currency field with 18 precision and 2 scale, matching the correct calculation. This fixes a potential issue where total precision was mistakenly used as left_digits, leading to incorrect fake data generation.

Author: jdschleicher

src/treecipe/src/RecipeFakerService.ts/SnowfakeryRecipeFakerService/SnowfakeryRecipeFakerService.ts

@@ -407,19 +407,20 @@ ${this.generateTabs(5)}${randomChoicesBreakdown}`;
     buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
         // Handle all numeric fields (number, currency, percent) with precision and optional scale
         const effectiveScale = scale ?? 0;
-        const maxValuePrecision = '9'.repeat(precision);
+        const maxNumbersLeftOfDecimal = '9'.repeat(precision - effectiveScale);
 
         if (effectiveScale === 0) {
-            return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxValuePrecision})${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxNumbersLeftOfDecimal})${this.closingRecipeSyntax}`;
         } else {
-            return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${maxValuePrecision}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${maxNumbersLeftOfDecimal}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
         }
     }
 
     buildCurrencyRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
         // Special handling for currency fields - use full precision as left_digits
         const effectiveScale = scale ?? 0;
-        return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${precision}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
+        const maxNumbersLeftOfDecimal = precision - effectiveScale;
+        return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${maxNumbersLeftOfDecimal}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
     }
 
 }

src/treecipe/src/RecipeService/tests/RecipeService.test.ts

@@ -136,7 +136,7 @@ describe('SnowfakeryRecipeService IRecipeService Implementation Shared Intstance
         test('given expected currency XMLFieldDetail, returns the expected snowfakery YAML recipe value', () => {
 
             const expectedXMLDetailForCurrency:XMLFieldDetail = XMLMarkupMockService.getCurrencyFieldDetail();
-            const expectedSnowfakeryValueForCurrency = '${{fake.pydecimal(left_digits=18, right_digits=2, positive=True)}}';
+            const expectedSnowfakeryValueForCurrency = '${{fake.pydecimal(left_digits=16, right_digits=2, positive=True)}}';
             const recordTypeNameByRecordTypeNameToXMLMarkup = {};
             const actualSnowfakeryValueForCurrency = recipeServiceWithSnow.getRecipeFakeValueByXMLFieldDetail(expectedXMLDetailForCurrency, recordTypeNameByRecordTypeNameToXMLMarkup);