feat(recipe-faker): add scale support to numeric recipe value generation

- Renamed `buildNumericRecipeValueWithPrecision` to `buildNumericRecipeValueWithPrecisionAndScale` in IRecipeFakerService and implementations
- Added optional `scale` parameter to handle decimal fields (currency, percent) with appropriate precision and decimal places
- Updated FakerJS and Snowfakery services to generate integers for scale=0 and decimals for scale>0
- Modified RecipeService to pass scale for percent fields, ensuring accurate fake data generation for numeric types

Author: jdschleicher

src/treecipe/src/RecipeFakerService.ts/FakerJSRecipeFakerService/FakerJSRecipeFakerService.ts

@@ -512,10 +512,19 @@ ${this.generateTabs(5)}${randomChoicesBreakdown}`;
         return `${this.openingRecipeSyntax} faker.lorem.text(${length}).substring(0, ${length}) ${this.closingRecipeSyntax}`;
     }
 
-    buildNumericRecipeValueWithPrecision(precision: number): string {
-        // For numeric fields, precision typically represents total digits, but we can use it to limit the range
-        const maxValue = Math.pow(10, precision) - 1;
-        return `${this.openingRecipeSyntax} faker.number.int({min: 0, max: ${maxValue}}) ${this.closingRecipeSyntax}`;
+    buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
+        // Handle all numeric fields (number, currency, percent) with precision and optional scale
+        const effectiveScale = scale ?? 0;
+
+        if (effectiveScale === 0) {
+            // Integer fields (number with scale=0, or scale not specified)
+            const maxValue = Math.pow(10, precision) - 1;
+            return `${this.openingRecipeSyntax} faker.number.int({min: 0, max: ${maxValue}}) ${this.closingRecipeSyntax}`;
+        } else {
+            // Decimal fields (currency, percent with scale > 0)
+            const maxValue = Math.pow(10, precision - effectiveScale) - Math.pow(10, -effectiveScale);
+            return `${this.openingRecipeSyntax} faker.finance.amount({min: 0, max: ${maxValue}, dec: ${effectiveScale}}) ${this.closingRecipeSyntax}`;
+        }
     }
 
 }

src/treecipe/src/RecipeFakerService.ts/IRecipeFakerService.ts

@@ -29,5 +29,5 @@ export interface IRecipeFakerService {
     getMultipicklistTODOPlaceholderWithExample(): string
     getStandardAndGlobalValueSetTODOPlaceholderWithExample(): string
     buildTextRecipeValueWithLength(length: number): string
-    buildNumericRecipeValueWithPrecision(precision: number): string
+    buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string
 }

src/treecipe/src/RecipeFakerService.ts/SnowfakeryRecipeFakerService/SnowfakeryRecipeFakerService.ts

@@ -404,10 +404,19 @@ ${this.generateTabs(5)}${randomChoicesBreakdown}`;
         return `${this.openingRecipeSyntax}fake.text(max_nb_chars=${length})${this.closingRecipeSyntax}`;
     }
 
-    buildNumericRecipeValueWithPrecision(precision: number): string {
-        // For numeric fields, precision typically represents total digits, but we can use it to limit the range
-        const maxValue = Math.pow(10, precision) - 1;
-        return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxValue})${this.closingRecipeSyntax}`;
+    buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
+        // Handle all numeric fields (number, currency, percent) with precision and optional scale
+        const effectiveScale = scale ?? 0;
+
+        if (effectiveScale === 0) {
+            // Integer fields (number with scale=0, or scale not specified)
+            const maxValue = Math.pow(10, precision) - 1;
+            return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxValue})${this.closingRecipeSyntax}`;
+        } else {
+            // Decimal fields (currency, percent with scale > 0)
+            const maxValue = Math.pow(10, precision - effectiveScale) - Math.pow(10, -effectiveScale);
+            return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${precision - effectiveScale}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
+        }
     }
 
 }

src/treecipe/src/RecipeService/RecipeService.ts

@@ -125,7 +125,7 @@ export class RecipeService {
                 case 'percent':
 
                     if (xmlFieldDetail.precision) {
-                        fakeRecipeValue = this.fakerService.buildNumericRecipeValueWithPrecision(xmlFieldDetail.precision);
+                        fakeRecipeValue = this.fakerService.buildNumericRecipeValueWithPrecisionAndScale(xmlFieldDetail.precision, xmlFieldDetail.scale);
                         return fakeRecipeValue;
                     }
                     // Fall through to default if no precision

src/treecipe/src/XMLProcessingService/XMLFieldDetail.ts

@@ -11,5 +11,6 @@ export class XMLFieldDetail {
     public xmlMarkup: string;
     public isStandardValueSet?: boolean;
     public precision?: number;
+    public scale?: number;
     public length?: number;
 }