refactor: simplify numeric value generation and add currency-specific method

- Refactored buildNumericRecipeValueWithPrecisionAndScale in FakerJS and Snowfakery services to remove redundant calculations and improve readability.
- Added buildCurrencyRecipeValueWithPrecisionAndScale method to handle currency fields separately, ensuring full precision usage.
- Updated IRecipeFakerService interface to include the new currency method.

Author: jdschleicher

src/treecipe/src/RecipeFakerService.ts/FakerJSRecipeFakerService/FakerJSRecipeFakerService.ts

@@ -513,25 +513,25 @@ ${this.generateTabs(5)}${randomChoicesBreakdown}`;
     }
 
     buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
-        // Handle all numeric fields (number, currency, percent) with precision and optional scale
+
         const effectiveScale = scale ?? 0;
+        const maxValueByPrecision = '9'.repeat(precision);
 
         if (effectiveScale === 0) {
-            // Integer fields (number with scale=0, or scale not specified)
-            // Cap precision at 15 to get accurate all-9's result (JavaScript can't represent larger integers)
-            const safePrecision = Math.min(precision, 18);
-            const maxValueString = '9'.repeat(safePrecision);
-            const maxValue = parseInt(maxValueString, 10);
-            return `${this.openingRecipeSyntax} faker.number.int({min: 0, max: ${maxValue}}) ${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax} faker.number.int({min: 0, max: ${maxValueByPrecision}}) ${this.closingRecipeSyntax}`;
         } else {
-            // Decimal fields (currency, percent with scale > 0)
-            // For decimal fields, precision includes decimal places, so max integer part is precision - scale
-            const integerPrecision = precision - effectiveScale;
-            const safeIntegerPrecision = Math.min(integerPrecision, 18);
-            const maxValueString = '9'.repeat(safeIntegerPrecision);
-            const maxValue = parseInt(maxValueString, 10);
-            return `${this.openingRecipeSyntax} faker.finance.amount({min: 0, max: ${maxValue}, dec: ${effectiveScale}}) ${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax} faker.finance.amount({min: 0, max: ${maxValueByPrecision}, dec: ${effectiveScale}}) ${this.closingRecipeSyntax}`;
         }
+
+    }
+
+    buildCurrencyRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
+        // Special handling for currency fields - use full precision as left_digits
+        const effectiveScale = scale ?? 0;
+        const maxValueByPrecision = '9'.repeat(precision);
+
+        return `${this.openingRecipeSyntax} faker.finance.amount({min: 0, max: ${maxValueByPrecision}, dec: ${effectiveScale}}) ${this.closingRecipeSyntax}`;
+   
     }
 
 }

src/treecipe/src/RecipeFakerService.ts/IRecipeFakerService.ts

@@ -30,4 +30,5 @@ export interface IRecipeFakerService {
     getStandardAndGlobalValueSetTODOPlaceholderWithExample(): string
     buildTextRecipeValueWithLength(length: number): string
     buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string
+    buildCurrencyRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string
 }

src/treecipe/src/RecipeFakerService.ts/SnowfakeryRecipeFakerService/SnowfakeryRecipeFakerService.ts

@@ -407,21 +407,19 @@ ${this.generateTabs(5)}${randomChoicesBreakdown}`;
     buildNumericRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
         // Handle all numeric fields (number, currency, percent) with precision and optional scale
         const effectiveScale = scale ?? 0;
+        const maxValuePrecision = '9'.repeat(precision);
 
         if (effectiveScale === 0) {
-            // Integer fields (number with scale=0, or scale not specified)
-            // Create max value by repeating '9' precision times, avoiding Math.pow precision issues
-            const maxValueString = '9'.repeat(precision);
-            const maxValue = parseInt(maxValueString, 10);
-            return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxValue})${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax}fake.random_int(min=0, max=${maxValuePrecision})${this.closingRecipeSyntax}`;
         } else {
-            // Decimal fields (currency, percent with scale > 0)
-            // For decimal fields, precision includes decimal places, so max integer part is precision - scale
-            const integerPrecision = precision - effectiveScale;
-            const maxValueString = '9'.repeat(integerPrecision);
-            const maxValue = parseInt(maxValueString, 10);
-            return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${integerPrecision}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
+            return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${maxValuePrecision}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
         }
     }
 
+    buildCurrencyRecipeValueWithPrecisionAndScale(precision: number, scale?: number): string {
+        // Special handling for currency fields - use full precision as left_digits
+        const effectiveScale = scale ?? 0;
+        return `${this.openingRecipeSyntax}fake.pydecimal(left_digits=${precision}, right_digits=${effectiveScale}, positive=True)${this.closingRecipeSyntax}`;
+    }
+
 }

src/treecipe/src/RecipeService/RecipeService.ts

@@ -121,7 +121,6 @@ export class RecipeService {
                     // Fall through to default if no length
 
                 case 'number':
-                case 'currency':
                 case 'percent':
 
                     if (xmlFieldDetail.precision) {
@@ -130,6 +129,14 @@ export class RecipeService {
                     }
                     // Fall through to default if no precision
 
+                case 'currency':
+
+                    if (xmlFieldDetail.precision) {
+                        fakeRecipeValue = this.fakerService.buildCurrencyRecipeValueWithPrecisionAndScale(xmlFieldDetail.precision, xmlFieldDetail.scale);
+                        return fakeRecipeValue;
+                    }
+                    // Fall through to default if no precision
+
                 default:
 
                     fakeRecipeValue = this.getFakeValueIfExpectedSalesforceFieldType(fieldType);

src/treecipe/src/RecipeService/tests/FakerJSRecipeService.test.ts

@@ -191,7 +191,7 @@ describe('FakerJSRecipeService IRecipeService Implementation Shared Intstance Te
         test('given expected number XMLFieldDetail, returns the expected fakerJS YAML recipe value', () => {
 
             const expectedXMLDetailForNumber:XMLFieldDetail = XMLMarkupMockService.getNumberXMLFieldDetail();
-            const expectedFakerJSExpressionForNumber = `\${{ faker.number.int({min: 0, max: 999999999999999}) }}`;
+            const expectedFakerJSExpressionForNumber = `\${{ faker.number.int({min: 0, max: 999999999999999999}) }}`;
             const recordTypeNameByRecordTypeNameToXMLMarkup = {};
 
             const actualFakerJSForNumber = recipeServiceWithFakerJS.getRecipeFakeValueByXMLFieldDetail(expectedXMLDetailForNumber, recordTypeNameByRecordTypeNameToXMLMarkup);
@@ -202,7 +202,7 @@ describe('FakerJSRecipeService IRecipeService Implementation Shared Intstance Te
         test('given expected currency XMLFieldDetail, returns the expected fakerJS YAML recipe value', () => {
 
             const expectedXMLDetailForCurrency:XMLFieldDetail = XMLMarkupMockService.getCurrencyFieldDetail();
-            const expectedFakerJSExpressionForCurrency = "\${{ faker.finance.amount({min: 0, max: 999999999999999, dec: 2}) }}";
+            const expectedFakerJSExpressionForCurrency = "\${{ faker.finance.amount({min: 0, max: 999999999999999999, dec: 2}) }}";
             const recordTypeNameByRecordTypeNameToXMLMarkup = {};
             const actualFakerJSForCurrency = recipeServiceWithFakerJS.getRecipeFakeValueByXMLFieldDetail(expectedXMLDetailForCurrency, recordTypeNameByRecordTypeNameToXMLMarkup);
 

src/treecipe/src/RecipeService/tests/RecipeService.test.ts

@@ -124,7 +124,7 @@ describe('SnowfakeryRecipeService IRecipeService Implementation Shared Intstance
         test('given expected number XMLFieldDetail, returns the expected snowfakery YAML recipe value', () => {
 
             const expectedXMLDetailForNumber:XMLFieldDetail = XMLMarkupMockService.getNumberXMLFieldDetail();
-            const expectedSnowfakeryValueForNumber = '${{fake.random_int(min=0, max=999999999999999)}}';
+            const expectedSnowfakeryValueForNumber = '${{fake.random_int(min=0, max=999999999999999999)}}';
             const recordTypeNameByRecordTypeNameToXMLMarkup = {};
 
             const actualSnowfakeryValueForNumber = recipeServiceWithSnow.getRecipeFakeValueByXMLFieldDetail(expectedXMLDetailForNumber, recordTypeNameByRecordTypeNameToXMLMarkup);
@@ -136,7 +136,7 @@ describe('SnowfakeryRecipeService IRecipeService Implementation Shared Intstance
         test('given expected currency XMLFieldDetail, returns the expected snowfakery YAML recipe value', () => {
 
             const expectedXMLDetailForCurrency:XMLFieldDetail = XMLMarkupMockService.getCurrencyFieldDetail();
-            const expectedSnowfakeryValueForCurrency = '${{fake.pydecimal(left_digits=16, right_digits=2, positive=True)}}';
+            const expectedSnowfakeryValueForCurrency = '${{fake.pydecimal(left_digits=18, right_digits=2, positive=True)}}';
             const recordTypeNameByRecordTypeNameToXMLMarkup = {};
             const actualSnowfakeryValueForCurrency = recipeServiceWithSnow.getRecipeFakeValueByXMLFieldDetail(expectedXMLDetailForCurrency, recordTypeNameByRecordTypeNameToXMLMarkup);