Refactor doc.rkt to become a proper reusable library #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the summary comments in `doc.rkt` and `safedoc.rkt` to better reflect their respective roles.
- Remove expand.rkt and consolidate expansion logic into check-syntax.rkt. - Refactor check-syntax.rkt to return CSResult instead of sending diagnostics directly. - Move diagnostic generation logic (error handling, Typed Racket log processing) from check-syntax.rkt to service/diagnostic.rkt. - Extend service/interface.rkt and base-service% with walk-log and walk-text methods. - Update safedoc.rkt to manage the new check-syntax workflow and push tasks to the scheduler. - Clean up doc.rkt by exposing doc-expand, doc-expand!, and doc-walk-text.
dannypsnl
reviewed
Jan 28, 2026
| @@ -0,0 +1,211 @@ | |||
| #lang racket | |||
|
|
|||
| (require rackunit | |||
Collaborator
There was a problem hiding this comment.
require rackunit at top-level will require info.rkt to treat rackunit-lib as deps (instead of build-deps), should we separate the project to multi-package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #168
This is an incomplete draft now.