Skip to content

Shader shows puddles when fog applied. #238

@0xCatPKG

Description

@0xCatPKG

When fog from resource packs is applied, shader starts drawing puddles on the ground. That may be related to weather detection
(Same issue also appears in nether #222)
That leads to custom biomes from addons being unplayable.

Expected Behavior

When fog is applied, terrain should be normal.

Current Behavior

When fog is applied, puddles appear on the terrain

Steps to Reproduce

  1. Get resource pack with custom fog(s)
  2. Apply fog with /fog @a push <fog identifier> test

Examples:

Video example

fog.json:

{
  "format_version": "1.16.100",
  "minecraft:fog_settings": {
    "description": {
      "identifier": "nature:mangrove_swamp_fog"
    },
    "distance": {
      "air": {
        "fog_start": 8.0,
        "fog_end": 96.0,
        "fog_color": "#778776",
        "render_distance_type": "fixed"
      },
      "water": {
        "fog_start": 0.0,
        "fog_end": 15.0,
        "fog_color": "#4c6559",
        "render_distance_type": "fixed"
      },
      "weather": {
        "fog_start": 8.0,
        "fog_end": 96.0,
        "fog_color": "#5c615c",
        "render_distance_type": "fixed"
      }
    }
  }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    critical bugSomething isn't workinghelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions