Added exceptions

Author: jeeftor

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "simplefin4py"
-version = "0.0.7"
+version = "0.0.8"
 description = ""
 authors = ["Jeef <[email protected]>"]
 readme = "README.md"

simplefin4py/exceptions.py

@@ -32,10 +32,18 @@ def __init__(self) -> None:
         super().__init__(self.message)
 
 
-class SimpleFinPaymentError(Exception):
+class SimpleFinPaymentRequiredError(Exception):
     """A 402 error will raise a Payment Required."""
 
     def __init__(self) -> None:
         """Initialize the exception."""
         self.message = "Payment Required"
         super().__init__(self.message)
+
+
+class SimpleFinInvalidAccountURLError(Exception):
+    """Invalid authorization URL."""
+
+    def __init__(self) -> None:
+        """Initialize the exception."""
+        self.message = "There was an issue parsing the Account URL."

simplefin4py/simplefin.py

@@ -8,7 +8,13 @@
 
 from aiohttp import BasicAuth, ClientConnectorError, ClientConnectorSSLError
 
-from .exceptions import SimpleFinClaimError, SimpleFinInvalidClaimTokenError
+from .exceptions import (
+    SimpleFinClaimError,
+    SimpleFinInvalidClaimTokenError,
+    SimpleFinInvalidAccountURLError,
+    SimpleFinPaymentRequiredError,
+    SimpleFinAuthError,
+)
 from .model import FinancialData
 from .const import LOGGER
 
@@ -62,16 +68,12 @@ def __init__(
         scheme, rest = access_url.split("//", 1)
         try:
             self.auth, rest = rest.split("@", 1)
-        except ValueError as e:
-            raise e
+        except ValueError as err:
+            raise SimpleFinInvalidAccountURLError from err
         self.url = scheme + "//" + rest + "/accounts"
         self.username, self.password = self.auth.split(":", 1)
         self.proxy: str | None = proxy
 
-        # self.auth already is this i think..??
-        # self.auth = BasicAuth(self.username, self.password)
-        # self.session = self._create_session(auth, verify_ssl)
-
     async def fetch_data(self) -> FinancialData:
         """Fetch financial data from SimpleFin and return as FinancialData object."""
         LOGGER.debug("Starting fetch_data in SimpleFin")
@@ -90,14 +92,19 @@ async def fetch_data(self) -> FinancialData:
                 response = await session.get(
                     self.access_url + "/accounts", **request_params
                 )
-                response.raise_for_status()
+
+                if response.status == 402:
+                    raise SimpleFinPaymentRequiredError()
+                if response.status == 403:
+                    raise SimpleFinAuthError()
+
                 data = await response.json()
                 LOGGER.debug(f"Received data: {data}")
                 financial_data: FinancialData = FinancialData.from_dict(data)  # type: ignore[attr-defined]
                 LOGGER.debug(f"Parsed FinancialData: {financial_data}")
                 return financial_data
-        except (ClientConnectorError, ClientConnectorSSLError) as e:
-            raise e
+        except (ClientConnectorError, ClientConnectorSSLError) as err:
+            raise err
         except Exception as e:
             print(e)
             raise e

tests/conftest.py

@@ -97,3 +97,12 @@ def mock_get_data_403(data_403: str) -> Generator[aioresponses, None, None]:
         # Mock a failed login attempt due to bad credentials.
         m.get(MOCK_ACCESS_URL + "/accounts", status=403, body=data_403)
         yield m
+
+
+@pytest.fixture()  # type: ignore
+def mock_get_data_generic_error() -> Generator[aioresponses, None, None]:
+    """Fixture for mocking a fech process with bad credentials/url."""
+    with aioresponses() as m:
+        # Mock a failed login attempt due to bad credentials.
+        m.get(MOCK_ACCESS_URL + "/accounts", status=200, body="<,asduB*J(_8asdji>")
+        yield m

tests/test_simplefin.py

@@ -1,11 +1,15 @@
 """Tests for stuff."""
 
-import aiohttp
 import pytest
 from aioresponses import aioresponses
 
 from simplefin4py import SimpleFin
-from simplefin4py.exceptions import SimpleFinInvalidClaimTokenError, SimpleFinClaimError
+from simplefin4py.exceptions import (
+    SimpleFinInvalidClaimTokenError,
+    SimpleFinClaimError,
+    SimpleFinPaymentRequiredError,
+    SimpleFinAuthError,
+)
 from tests.conftest import MOCK_ACCESS_URL
 
 
@@ -40,15 +44,15 @@ async def test_claim_token_403(mock_claim_token_403, mock_claim_token):
 async def test_access_402(mock_get_data_402) -> None:
     """Test a failed access token."""
     sf = SimpleFin(MOCK_ACCESS_URL)
-    with pytest.raises(aiohttp.client_exceptions.ClientResponseError):
+    with pytest.raises(SimpleFinPaymentRequiredError):
         await sf.fetch_data()
 
 
 @pytest.mark.asyncio  # type: ignore
 async def test_access_403(mock_get_data_403) -> None:
     """Test a failed access token."""
     sf = SimpleFin(MOCK_ACCESS_URL)
-    with pytest.raises(aiohttp.client_exceptions.ClientResponseError):
+    with pytest.raises(SimpleFinAuthError):
         await sf.fetch_data()