Skip to content

Commit bd04dae

Browse files
authored
fix(cli): broken --show-config command (#419)
Fix and improve the command.
1 parent d5c20d1 commit bd04dae

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515

1616
- Added CI for broken HTML links and fixed, plus spell checking.
1717
[#417](https://github.com/jeertmans/manim-slides/pull/417)
18-
- Create FAQ page and clear FAQ from README.md
18+
- Create FAQ page and clear FAQ from README.md.
1919
[#418](https://github.com/jeertmans/manim-slides/pull/418)
2020

21+
(unreleased-fixed)=
22+
### Fixed
23+
24+
- Fixed broken `--show-config` command.
25+
[#419](https://github.com/jeertmans/manim-slides/pull/419)
26+
2127

2228
(v5.1.4)=
2329
## [v5.1.4](https://github.com/jeertmans/manim-slides/compare/v5.1.3...v5.1.4)

docs/source/faq.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Questions related to `manim-slides render [SCENES]...`,
2525

2626
### I cannot render with ManimGL
2727

28-
ManimGL support is only garanteed to work
28+
ManimGL support is only guaranteed to work
2929
on a very minimal set of versions, because it differs quite a lot from ManimCE,
3030
and its development is not very active.
3131

manim_slides/convert.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -568,11 +568,14 @@ def callback(ctx: Context, param: Parameter, value: bool) -> None:
568568

569569
to = ctx.params.get("to", "html")
570570

571-
converter = Converter.from_string(to)(
572-
presentation_configs=[PresentationConfig()]
573-
)
574-
for key, value in converter.dict().items():
575-
click.echo(f"{key}: {value!r}")
571+
converter = Converter.from_string(to)
572+
573+
for key, field in converter.model_fields.items():
574+
if field.is_required():
575+
continue
576+
577+
default = field.get_default(call_default_factory=True)
578+
click.echo(f"{key}: {default}")
576579

577580
ctx.exit()
578581

0 commit comments

Comments
 (0)