Skip to content

Commit bd9bf06

Browse files
authored
chore(cli): remove unused PERF verbosity level (#245)
* chore(cli): remove unused PERF verbosity level As titled. * fix(tests): remove perf in tests
1 parent 4d76f2c commit bd9bf06

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,5 @@ In an effort to better document changes, this CHANGELOG document is now created.
5252
- Removed the following options from `manim-slides present`:
5353
`--resolution`, `--record-to`, `--resize-mode`, and `--background-color`.
5454
[#243](https://github.com/jeertmans/manim-slides/pull/243)
55+
- Removed `PERF` verbosity level because not used anymore.
56+
[#245](https://github.com/jeertmans/manim-slides/pull/245)

manim_slides/commons.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ def callback(ctx: Context, param: Parameter, value: str) -> None:
5454
"-v",
5555
"--verbosity",
5656
type=click.Choice(
57-
["PERF", "DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"],
57+
["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"],
5858
case_sensitive=False,
5959
),
60-
help="Verbosity of CLI output. PERF will log performances (timing) information.",
60+
help="Verbosity of CLI output.",
6161
default=None,
6262
expose_value=False,
6363
envvar="MANIM_SLIDES_VERBOSITY",

manim_slides/logger.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
from rich.console import Console
99
from rich.logging import RichHandler
10-
from rich.theme import Theme
1110

1211
__all__ = ["logger", "make_logger"]
1312

@@ -36,9 +35,8 @@ def make_logger() -> logging.Logger:
3635
RichHandler.KEYWORDS = HIGHLIGHTED_KEYWORDS
3736
rich_handler = RichHandler(
3837
show_time=True,
39-
console=Console(theme=Theme({"logging.level.perf": "magenta"})),
38+
console=Console(),
4039
)
41-
logging.addLevelName(5, "PERF")
4240
logger = logging.getLogger("manim-slides")
4341
logger.setLevel(logging.getLogger("manim").level)
4442
logger.addHandler(rich_handler)

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from manim_slides.config import PresentationConfig
99
from manim_slides.logger import make_logger
1010

11-
_ = make_logger() # This is run so that "PERF" level is created
11+
_ = make_logger() # This is run so that logger is created
1212

1313

1414
@pytest.fixture

tests/test_commons.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def main(folder: Path) -> None:
9595

9696
@pytest.mark.parametrize(
9797
("verbosity",),
98-
[("PeRF",), ("DEBUG",), ("info",), ("waRNING",), ("eRRor",), ("CrItIcAl",)],
98+
[("DEBUG",), ("info",), ("waRNING",), ("eRRor",), ("CrItIcAl",)],
9999
)
100100
def test_valid_verbosity_option(verbosity: str) -> None:
101101
@click.command()

0 commit comments

Comments
 (0)