Skip to content

Commit 10de757

Browse files
committed
Merge branch 'ab/send-email-config-fix'
Regression fix. * ab/send-email-config-fix: send-email: fix a "first config key wins" regression in v2.33.0
2 parents e833224 + b996f84 commit 10de757

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

git-send-email.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ sub read_config {
376376
@$target = @values;
377377
}
378378
else {
379-
my $v = $known_keys->{$key}->[0];
379+
my $v = $known_keys->{$key}->[-1];
380380
next unless defined $v;
381381
next if $configured->{$setting}++;
382382
$$target = $v;

t/t9001-send-email.sh

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1533,6 +1533,21 @@ test_expect_success $PREREQ 'sendemail.8bitEncoding works' '
15331533
test_cmp content-type-decl actual
15341534
'
15351535

1536+
test_expect_success $PREREQ 'sendemail.8bitEncoding in .git/config overrides --global .gitconfig' '
1537+
clean_fake_sendmail &&
1538+
git config sendemail.assume8bitEncoding UTF-8 &&
1539+
test_when_finished "rm -rf home" &&
1540+
mkdir home &&
1541+
git config -f home/.gitconfig sendemail.assume8bitEncoding "bogus too" &&
1542+
echo bogus |
1543+
env HOME="$(pwd)/home" DEBUG=1 \
1544+
1545+
--smtp-server="$(pwd)/fake.sendmail" \
1546+
email-using-8bit >stdout &&
1547+
egrep "Content|MIME" msgtxt1 >actual &&
1548+
test_cmp content-type-decl actual
1549+
'
1550+
15361551
test_expect_success $PREREQ '--8bit-encoding overrides sendemail.8bitEncoding' '
15371552
clean_fake_sendmail &&
15381553
git config sendemail.assume8bitEncoding "bogus too" &&

0 commit comments

Comments
 (0)