Skip to content

Commit 382b601

Browse files
peffgitster
authored andcommitted
ll_union_merge(): rename path_unused parameter
The "path" parameter to ll_union_merge() is named "path_unused", since we don't ourselves use it. But we do pass it to ll_xdl_merge(), which may look at it (it gets passed to ll_binary_merge(), which may pass it to warning()). Let's rename it to correct this inaccuracy (both of the other functions correctly do not call this "unused"). Note that we also pass drv_unused, but it truly is unused by the rest of the stack (it only exists at all to provide a generic interface that matches what ll_ext_merge() needs). Reported-by: Elijah Newren <[email protected]> Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7f53f78 commit 382b601

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ll-merge.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ static int ll_xdl_merge(const struct ll_merge_driver *drv_unused,
138138

139139
static int ll_union_merge(const struct ll_merge_driver *drv_unused,
140140
mmbuffer_t *result,
141-
const char *path_unused,
141+
const char *path,
142142
mmfile_t *orig, const char *orig_name,
143143
mmfile_t *src1, const char *name1,
144144
mmfile_t *src2, const char *name2,
@@ -150,7 +150,7 @@ static int ll_union_merge(const struct ll_merge_driver *drv_unused,
150150
assert(opts);
151151
o = *opts;
152152
o.variant = XDL_MERGE_FAVOR_UNION;
153-
return ll_xdl_merge(drv_unused, result, path_unused,
153+
return ll_xdl_merge(drv_unused, result, path,
154154
orig, orig_name, src1, name1, src2, name2,
155155
&o, marker_size);
156156
}

0 commit comments

Comments
 (0)