Skip to content

Commit 9516345

Browse files
peffgitster
authored andcommitted
t5702: use test_commit_bulk
There are two loops that create 32 commits each using test_commit. Using test_commit_bulk speeds this up from: Benchmark #1: ./t5702-protocol-v2.sh --root=/var/ram/git-tests Time (mean ± σ): 5.409 s ± 0.513 s [User: 2.382 s, System: 2.466 s] Range (min … max): 4.633 s … 5.927 s 10 runs to: Benchmark #1: ./t5702-protocol-v2.sh --root=/var/ram/git-tests Time (mean ± σ): 3.956 s ± 0.242 s [User: 1.775 s, System: 1.627 s] Range (min … max): 3.449 s … 4.239 s 10 runs for an average savings of over 25%. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 737b19b commit 9516345

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

t/t5702-protocol-v2.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -499,10 +499,7 @@ test_expect_success 'upload-pack respects client shallows' '
499499
500500
# Add extra commits to the client so that the whole fetch takes more
501501
# than 1 request (due to negotiation)
502-
for i in $(test_seq 1 32)
503-
do
504-
test_commit -C client c$i
505-
done &&
502+
test_commit_bulk -C client --id=c 32 &&
506503
507504
git -C server checkout -b newbranch base &&
508505
test_commit -C server client_wants &&
@@ -711,10 +708,7 @@ test_expect_success 'when server does not send "ready", expect FLUSH' '
711708
# Create many commits to extend the negotiation phase across multiple
712709
# requests, so that the server does not send "ready" in the first
713710
# request.
714-
for i in $(test_seq 1 32)
715-
do
716-
test_commit -C http_child c$i
717-
done &&
711+
test_commit_bulk -C http_child --id=c 32 &&
718712
719713
# After the acknowledgments section, pretend that a DELIM
720714
# (0001) was sent instead of a FLUSH (0000).

0 commit comments

Comments
 (0)