Skip to content

Commit b6bd704

Browse files
committed
Merge branch 'dc/p4-binary-submit-fix'
Prevent "git p4" from failing to submit changes to binary file. * dc/p4-binary-submit-fix: git-p4: fix failed submit by skip non-text data files
2 parents d2992c6 + 54662d5 commit b6bd704

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

git-p4.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1977,8 +1977,11 @@ def get_diff_description(self, editedFiles, filesToAdd, symlinks):
19771977
newdiff += "+%s\n" % os.readlink(newFile)
19781978
else:
19791979
f = open(newFile, "r")
1980-
for line in f.readlines():
1981-
newdiff += "+" + line
1980+
try:
1981+
for line in f.readlines():
1982+
newdiff += "+" + line
1983+
except UnicodeDecodeError:
1984+
pass # Found non-text data and skip, since diff description should only include text
19821985
f.close()
19831986

19841987
return (diff + newdiff).replace('\r\n', '\n')

0 commit comments

Comments
 (0)