Skip to content

Commit b81a85e

Browse files
committed
Merge branch 'js/log-protocol-version'
Debugging aid. * js/log-protocol-version: connect, protocol: log negotiated protocol version
2 parents 8778fa8 + 626beeb commit b81a85e

File tree

3 files changed

+15
-0
lines changed

3 files changed

+15
-0
lines changed

connect.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,8 @@ enum protocol_version discover_version(struct packet_reader *reader)
164164
BUG("unknown protocol version");
165165
}
166166

167+
trace2_data_intmax("transfer", NULL, "negotiated-version", version);
168+
167169
return version;
168170
}
169171

protocol.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ enum protocol_version determine_protocol_version_server(void)
7373
string_list_clear(&list, 0);
7474
}
7575

76+
trace2_data_intmax("transfer", NULL, "negotiated-version", version);
77+
7678
return version;
7779
}
7880

t/t5705-session-id-in-capabilities.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,17 @@ do
7373
grep \"key\":\"server-sid\" tr2-client-events &&
7474
grep \"key\":\"client-sid\" tr2-server-events
7575
'
76+
77+
test_expect_success "client & server log negotiated version (v${PROTO})" '
78+
test_when_finished "rm -rf local tr2-client-events tr2-server-events" &&
79+
cp -r "$LOCAL_PRISTINE" local &&
80+
GIT_TRACE2_EVENT="$(pwd)/tr2-client-events" \
81+
git -c protocol.version=$PROTO -C local fetch \
82+
--upload-pack "GIT_TRACE2_EVENT=\"$(pwd)/tr2-server-events\" git-upload-pack" \
83+
origin &&
84+
grep \"key\":\"negotiated-version\",\"value\":\"$PROTO\" tr2-client-events &&
85+
grep \"key\":\"negotiated-version\",\"value\":\"$PROTO\" tr2-server-events
86+
'
7687
done
7788

7889
test_done

0 commit comments

Comments
 (0)