Skip to content

Commit ddcb189

Browse files
ttaylorrgitster
authored andcommitted
pack-bitmap: clarify comment in filter_bitmap_exclude_type()
The code that eventually became filter_bitmap_exclude_type() was originally introduced in 4f3bd56 (pack-bitmap: implement BLOB_NONE filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps. In 856e12c (pack-bitmap.c: make object filtering functions generic, 2020-05-04), it became filter_bitmap_exclude_type(). But not all of the comments were updated to be agnostic to the provided type. Remove the remaining comments which should have been updated in 856e12c to reflect the type-agnostic nature of the function. Signed-off-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9639474 commit ddcb189

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

pack-bitmap.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -762,8 +762,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
762762
tips = find_tip_objects(bitmap_git, tip_objects, type);
763763

764764
/*
765-
* We can use the blob type-bitmap to work in whole words
766-
* for the objects that are actually in the bitmapped packfile.
765+
* We can use the type-level bitmap for 'type' to work in whole
766+
* words for the objects that are actually in the bitmapped
767+
* packfile.
767768
*/
768769
for (i = 0, init_type_iterator(&it, bitmap_git, type);
769770
i < to_filter->word_alloc && ewah_iterator_next(&mask, &it);
@@ -774,9 +775,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
774775
}
775776

776777
/*
777-
* Clear any blobs that weren't in the packfile (and so would not have
778-
* been caught by the loop above. We'll have to check them
779-
* individually.
778+
* Clear any objects that weren't in the packfile (and so would
779+
* not have been caught by the loop above. We'll have to check
780+
* them individually.
780781
*/
781782
for (i = 0; i < eindex->count; i++) {
782783
uint32_t pos = i + bitmap_git->pack->num_objects;

0 commit comments

Comments
 (0)