Skip to content

Commit 03e79de

Browse files
lategoodbyekuba-moo
authored andcommitted
net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk_enable()
The function of_phy_find_device may return NULL, so we need to take care before dereferencing phy_dev. Fixes: 64a632d ("net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()") Signed-off-by: Stefan Wahren <[email protected]> Cc: Christoph Niedermaier <[email protected]> Cc: Richard Leitner <[email protected]> Reviewed-by: Simon Horman <[email protected]> Reviewed-by: Wei Fang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 157cf36 commit 03e79de

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/freescale/fec_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2363,7 +2363,8 @@ static void fec_enet_phy_reset_after_clk_enable(struct net_device *ndev)
23632363
*/
23642364
phy_dev = of_phy_find_device(fep->phy_node);
23652365
phy_reset_after_clk_enable(phy_dev);
2366-
put_device(&phy_dev->mdio.dev);
2366+
if (phy_dev)
2367+
put_device(&phy_dev->mdio.dev);
23672368
}
23682369
}
23692370

0 commit comments

Comments
 (0)